Use name or metric_name as namespace for weaver diff on signal differences.#784
Merged
jsuereth merged 9 commits intoopen-telemetry:mainfrom Jun 12, 2025
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…renamed to. However, we need a general discussion on what these signal changes mean overall.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #784 +/- ##
=======================================
+ Coverage 75.9% 76.3% +0.3%
=======================================
Files 69 69
Lines 5510 5545 +35
=======================================
+ Hits 4187 4233 +46
+ Misses 1323 1312 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jsuereth
changed the title
name or metric_name as namespace for weaver diff on signal differences.
github-project-automation
Bot
moved this from Next Release
to Done
in OTel Weaver Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #776. First step for #785.
This PR:
metric_name.nameis guaranteed to be unique via validation done on resolved registries. So ismetric_name.extendsis wonky on signals, as they cannot actually use the same name, so that use case isn't supported.Out of Scope for this PR:
weaver diff. I have a simple path forward laid out in Path forward foridvsnameand weaver diff #785 that I think can be a quick follow upNotes:
weaver diffintegration tests actually already usednameon span groups.