Allow attributes to be identifying or descriptive.#735
Merged
jsuereth merged 8 commits intoopen-telemetry:mainfrom May 15, 2025
Merged
Allow attributes to be identifying or descriptive.#735jsuereth merged 8 commits intoopen-telemetry:mainfrom
jsuereth merged 8 commits intoopen-telemetry:mainfrom
Conversation
Closed
5 tasks
lquerel
approved these changes
May 9, 2025
Contributor
lquerel
left a comment
There was a problem hiding this comment.
Made 2 minor comments, otherwise LGTM
lmolkova
reviewed
May 12, 2025
lmolkova
approved these changes
May 12, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #735 +/- ##
=====================================
Coverage 76.7% 76.7%
=====================================
Files 65 65
Lines 5012 5030 +18
=====================================
+ Hits 3846 3860 +14
- Misses 1166 1170 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the next phase of open-telemetry/semantic-conventions#2246.
What this does:
rolefield to Attribute with optionsIdentifyingorDescriptiverolechangesWhat this does not do:
role.Why role
Why do we call this
role? I did some investigation into names and actually thought LLM captured some considerations well, here's (snipped) output: