Add Embed option for single attributes#212
Merged
lquerel merged 10 commits intoopen-telemetry:mainfrom Jun 28, 2024
Merged
Conversation
lquerel
reviewed
Jun 13, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
=======================================
+ Coverage 73.5% 74.2% +0.7%
=======================================
Files 45 44 -1
Lines 2983 2960 -23
=======================================
+ Hits 2194 2199 +5
+ Misses 789 761 -28 ☔ View full report in Codecov by Sentry. |
3 tasks
Contributor
|
@trisch-me could you update your PR with the last main branch so we could include this PR in the next release. Thanks |
Contributor
Author
|
@lquerel I have updated and added tests. local coverage shows me 68%. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds embedded option for specific attribute (first part of open-telemetry/build-tools#240)