Skip to content

Replace metric requirement level with generic (for all signals) one#1515

Merged
lmolkova merged 7 commits into
open-telemetry:mainfrom
lmolkova:signal-req-level
Jun 18, 2026
Merged

Replace metric requirement level with generic (for all signals) one#1515
lmolkova merged 7 commits into
open-telemetry:mainfrom
lmolkova:signal-req-level

Conversation

@lmolkova

Copy link
Copy Markdown
Member

Fix #1484

We didn't release weaver after metric_requirement_level was introduced, so it's ok to rename it without any back-compat.

This is only part of v2 definition / resolved / forge schema now.

@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.65217% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.5%. Comparing base (c6396c4) to head (16be258).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/weaver_resolved_schema/src/lib.rs 0.0% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1515   +/-   ##
=====================================
  Coverage   82.4%   82.5%           
=====================================
  Files        128     129    +1     
  Lines      10535   10566   +31     
=====================================
+ Hits        8682    8717   +35     
+ Misses      1853    1849    -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lquerel lquerel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsuereth

Copy link
Copy Markdown
Contributor

This needs docs regenerated

@lmolkova
lmolkova enabled auto-merge (squash) June 18, 2026 21:07
@lmolkova
lmolkova merged commit b98196d into open-telemetry:main Jun 18, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Requirement levels for all signals

3 participants