Replace metric requirement level with generic (for all signals) one#1515
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1515 +/- ##
=====================================
Coverage 82.4% 82.5%
=====================================
Files 128 129 +1
Lines 10535 10566 +31
=====================================
+ Hits 8682 8717 +35
+ Misses 1853 1849 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lmolkova
force-pushed
the
signal-req-level
branch
from
June 17, 2026 22:47
7ec3c4c to
3b427e7
Compare
jsuereth
approved these changes
Jun 18, 2026
Contributor
|
This needs docs regenerated |
lmolkova
force-pushed
the
signal-req-level
branch
from
June 18, 2026 21:06
b365d2a to
16be258
Compare
lmolkova
enabled auto-merge (squash)
June 18, 2026 21:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1484
We didn't release weaver after metric_requirement_level was introduced, so it's ok to rename it without any back-compat.
This is only part of v2 definition / resolved / forge schema now.