Skip to content

Remove vendored openssl dependency#1380

Merged
jsuereth merged 3 commits into
open-telemetry:mainfrom
sapatrjv:dev/sapatr/usenativetls
Apr 22, 2026
Merged

Remove vendored openssl dependency#1380
jsuereth merged 3 commits into
open-telemetry:mainfrom
sapatrjv:dev/sapatr/usenativetls

Conversation

@sapatrjv

@sapatrjv sapatrjv commented Apr 22, 2026 •
edited by jmacd
Loading

Copy link
Copy Markdown
Contributor

The OTel Dataflow Engine (aka otel-arrow) has been using Weaver. In weaver due to dependency on openssl vendored feature it causes openssl build everytime. This change is made to avoid such overhead. With this change weaver will rely on windoows native tls implementation.

Part of #1382.

Part of open-telemetry/otel-arrow#2697.

@sapatrjv
sapatrjv requested a review from a team as a code owner April 22, 2026 00:01
@codecov

codecov Bot commented Apr 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.8%. Comparing base (d8b3311) to head (07de75d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@          Coverage Diff          @@
##            main   #1380   +/-   ##
=====================================
  Coverage   81.8%   81.8%           
=====================================
  Files        119     119           
  Lines       9938    9938           
=====================================
  Hits        8137    8137           
  Misses      1801    1801

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jsuereth
jsuereth approved these changes Apr 22, 2026
View reviewed changes

@jsuereth jsuereth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for issuing a fix here! I'm wondering if we can more aggressive at turning off the OpenSSL requirement

Comment thread crates/weaver_common/Cargo.toml
# Use vendored OpenSSL on non-Windows platforms to avoid system OpenSSL deps
# This enables the "vendored" feature for the openssl crate when building on
# non-Windows targets.
[target.'cfg(not(windows))'.dependencies]

@jsuereth jsuereth Apr 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change this so we only vendor on MUSL deployments? I think that's the only platform where we ran into trouble and needed it...

@jsuereth

jsuereth commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

We discussed in semconv tooling SIG - We're going to work on extracting the entire SSL embedding as a feature of weaver over time, and dramatically clean up our build so things we need for a docker container don't bleed into decisions for platform-specific distributions.

This is good to merge for now.

@jsuereth
jsuereth enabled auto-merge (squash) April 22, 2026 14:42
@jsuereth jsuereth mentioned this pull request Apr 22, 2026
Open
@jsuereth
jsuereth merged commit 8aa8612 into open-telemetry:main Apr 22, 2026
23 checks passed
@sapatrjv
sapatrjv deleted the dev/sapatr/usenativetls branch April 22, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsuereth jsuereth jsuereth approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sapatrjv @jsuereth