Support cloning private repositories#1306
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1306 +/- ##
=====================================
Coverage 81.2% 81.2%
=====================================
Files 111 111
Lines 9371 9377 +6
=====================================
+ Hits 7615 7620 +5
- Misses 1756 1757 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jsuereth
approved these changes
Mar 23, 2026
jsuereth
left a comment
jsuereth
left a comment
Contributor
There was a problem hiding this comment.
Approving this for now, so we can enable a critical use case
| fs_capabilities: None, | ||
| }, | ||
| open::Options::isolated(), | ||
| open::Options::default(), |
Contributor
There was a problem hiding this comment.
Should this be a flag in weaver?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
--allow-git-credentialsglobal flag to use default git open options instead of isolated mode when cloning repositories, enabling system credential helpers (e.g.osxkeychain,manager,libsecret) for private repository access.