Skip to content

Update code so weaver check now supports v2 schema.#1016

Merged
jsuereth merged 22 commits into
open-telemetry:mainfrom
jsuereth:wip-v2-weaver-check
Nov 24, 2025
Merged

Update code so weaver check now supports v2 schema.#1016
jsuereth merged 22 commits into
open-telemetry:mainfrom
jsuereth:wip-v2-weaver-check

Conversation

@jsuereth

@jsuereth jsuereth commented Nov 19, 2025

Copy link
Copy Markdown
Contributor
  • Adds a new flag which will force all policies to use new v2 schema
  • Tests after_resolution policy against v2 schema
  • Tests comparison with baseline policy with v2 schema
  • Adds warning to before_resolution for v2 schema and policies. (We will not support before_resolution in v2, for now)

Comment thread src/registry/check.rs Fixed
Comment thread src/registry/check.rs Fixed
Comment thread src/util.rs Fixed
Comment thread src/util.rs Fixed
@codecov

codecov Bot commented Nov 19, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.6%. Comparing base (2cdae95) to head (c71929f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/weaver_resolved_schema/src/v2/mod.rs 64.2% 5 Missing ⚠️
crates/weaver_resolved_schema/src/error.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1016     +/-   ##
=======================================
- Coverage   78.7%   78.6%   -0.1%     
=======================================
  Files         82      82             
  Lines       6606    6612      +6     
=======================================
+ Hits        5200    5202      +2     
- Misses      1406    1410      +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/registry/check.rs Fixed
Comment thread src/registry/check.rs Fixed
Comment thread src/registry/check.rs Fixed
Comment thread src/registry/check.rs Fixed

@lmolkova lmolkova left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out in semconv, works like a charm!

Comment thread src/registry/mod.rs Outdated
Comment thread crates/weaver_resolved_schema/src/v2/mod.rs Fixed
Comment thread crates/weaver_resolved_schema/src/v2/mod.rs Fixed
Comment thread src/registry/check.rs Fixed
Comment thread src/registry/check.rs Fixed
Comment thread src/util.rs Fixed
Comment thread src/util.rs Fixed
Comment thread src/util.rs Fixed
Comment thread src/util.rs Fixed

@jerbly jerbly left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsuereth
jsuereth enabled auto-merge (squash) November 24, 2025 12:20
@jsuereth
jsuereth merged commit 1511626 into open-telemetry:main Nov 24, 2025
20 checks passed
@jsuereth
jsuereth deleted the wip-v2-weaver-check branch January 26, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants