Skip to content

live check: json output is racy #1133

Description

@xrmx

Describe the bug

If metrics are recevied then the traces are not serialized anymore in the output files.

To Reproduce
Steps to reproduce the behavior:

  1. ./target/release/weaver registry live-check --inactivity-timeout=15 --no-stats --format=json --output foo
  2. Send traces and metrics from instrumented application
  3. In the foo/live_check.json I have only metrics

If I disable sending metrics from the instrumented application I see the traces.

Expected behavior

In the foo/live_check.json I have both metrics and traces

Additional context

Current git hash is ea50701

Tip: React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it. Learn more here.

Metadata

Metadata

Assignees

Labels

live-checkRelated to the live-check feature

Type

Fields

No fields configured for Bug.

Projects

Status
Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions