Skip to content

feat: add k8s.container.status.last_terminated_reason resource attribute#968

Merged
lmolkova merged 2 commits intoopen-telemetry:mainfrom
povilasv:k8s-status
Apr 30, 2024
Merged

feat: add k8s.container.status.last_terminated_reason resource attribute#968
lmolkova merged 2 commits intoopen-telemetry:mainfrom
povilasv:k8s-status

Conversation

@povilasv
Copy link
Copy Markdown
Contributor

Fixes #922

Changes

Merge requirement checklist

@povilasv povilasv force-pushed the k8s-status branch 2 times, most recently from c344e0b to 3ce96d8 Compare April 25, 2024 11:34
@povilasv povilasv marked this pull request as ready for review April 25, 2024 11:35
@povilasv povilasv requested review from a team April 25, 2024 11:35
Comment thread model/registry/k8s.yaml
@ChrsMark
Copy link
Copy Markdown
Member

FYI @open-telemetry/specs-semconv-approvers @open-telemetry/specs-semconv-maintainers

Copy link
Copy Markdown
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Left a couple of minor comments

Comment thread .chloggen/k8s-status.yaml Outdated
Comment thread model/resource/k8s.yaml Outdated
@povilasv
Copy link
Copy Markdown
Contributor Author

@lmolkova updated based on your feedback, please take a look again 🙇

@lmolkova lmolkova merged commit 3dc61e1 into open-telemetry:main Apr 30, 2024
@povilasv povilasv deleted the k8s-status branch April 30, 2024 04:17
drewby pushed a commit to drewby/otel-semantic-conventions that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add k8s.container.status.last_terminated_reason to semantic conventions.

6 participants