Skip to content

Rename db.client.connections.* metrics to db.client.connection.* and rename db.client.connection.usage to db.client.connection.count and adapting units#966

Merged
lmolkova merged 17 commits intoopen-telemetry:mainfrom
gregkalapos:RenameDbClientConnectionUsage
May 2, 2024
Merged

Rename db.client.connections.* metrics to db.client.connection.* and rename db.client.connection.usage to db.client.connection.count and adapting units#966
lmolkova merged 17 commits intoopen-telemetry:mainfrom
gregkalapos:RenameDbClientConnectionUsage

Conversation

@gregkalapos
Copy link
Copy Markdown
Member

@gregkalapos gregkalapos commented Apr 24, 2024 •
edited by trask
Loading

Fixes #967
Fixes #201
Fixes #381

Changes

As described in #201 and discussed in the DB Semconv Stability WG meeting: db.client.connection.usage -> db.client.connection.count. Also fixing #967 and renaming the db.client.connections.* metrics namespace to db.client.connection.*.

Since this PR already changes Db metrics, also adapting unit from ms to s as described in #381.

Merge requirement checklist

gregkalapos
gregkalapos commented Apr 24, 2024
View reviewed changes
Comment thread model/metrics/database-metrics.yaml
@gregkalapos gregkalapos marked this pull request as ready for review April 24, 2024 20:11
@gregkalapos gregkalapos requested review from a team April 24, 2024 20:11
trask
trask reviewed Apr 24, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it may be worth fixing #967 in this PR also

Comment thread model/metrics/database-metrics.yaml Outdated
Comment thread model/metrics/database-metrics.yaml
lmolkova
lmolkova reviewed Apr 24, 2024
View reviewed changes
Comment thread model/metrics/database-metrics.yaml Outdated
@gregkalapos gregkalapos mentioned this pull request Apr 25, 2024
Closed
gregkalapos
gregkalapos commented Apr 25, 2024
View reviewed changes
Comment thread model/metrics/deprecated/database.yaml Outdated
@gregkalapos gregkalapos changed the title Rename db.client.connections.usage to db.client.connections.count Rename db.client.connections.* metrics to db.client.connection.* and rename db.client.connection.usage to db.client.connection.count Apr 25, 2024
trask
trask reviewed Apr 26, 2024
View reviewed changes
Comment thread docs/database/database-metrics.md Outdated
Comment thread model/metrics/database-metrics.yaml Outdated
trask
trask reviewed Apr 26, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gregkalapos sorry, I realized it would be good to add one more change to this PR: #381

bundling #381 here would have the advantage that we know the old name is always associated with milliseconds and the new name is always associated with seconds

(and it would affect the schema translation, where the metrics that changed from milliseconds to seconds would no longer be considered renames)

@gregkalapos gregkalapos changed the title Rename db.client.connections.* metrics to db.client.connection.* and rename db.client.connection.usage to db.client.connection.count Rename db.client.connections.* metrics to db.client.connection.* and rename db.client.connection.usage to db.client.connection.count and adapting units Apr 29, 2024
@gregkalapos gregkalapos mentioned this pull request Apr 29, 2024
Closed
trisch-me
trisch-me reviewed Apr 29, 2024
View reviewed changes
Comment thread schema-next.yaml
trisch-me
trisch-me reviewed Apr 30, 2024
View reviewed changes
Comment thread model/metrics/deprecated/database.yaml Outdated
@gregkalapos
Copy link
Copy Markdown
Member Author

gregkalapos commented Apr 30, 2024 •
edited
Loading

CI fails, dotnet doesn't ❤️ me:

Run dotnet tool update -g docfx --version "3.0.0-*" --add-source https://docfx.pkgs.visualstudio.com/docfx/_packaging/docs-public-packages/nuget/v3/index.json
/tmp/837413a5-82a5-4ef9-abd4-39c1160faf4a/restore.csproj : error NU1102: Unable to find package docfx with version (>= 3.0.0)
/tmp/837413a5-82a5-4ef9-abd4-39c1160faf4a/restore.csproj : error NU1102:   - Found 224 version(s) in nuget.org [ Nearest version: 2.76.0 ]
/tmp/837413a5-82a5-4ef9-abd4-39c1160faf4a/restore.csproj : error NU1102:   - Found 0 version(s) in https://docfx.pkgs.visualstudio.com/docfx/_packaging/docs-public-packages/nuget/v3/index.json
Tool 'docfx' failed to update due to the following:
The tool package could not be restored.
Tool 'docfx' failed to install. This failure may have been caused by:

* You are attempting to install a preview release and did not use the --version option to specify the version.
* A package by this name was found, but it was not a .NET tool.
* The required NuGet feed cannot be accessed, perhaps because of an Internet connection problem.
* You mistyped the name of the tool.

For more reasons, including package naming enforcement, visit https://aka.ms/failure-installing-tool
Error: Process completed with exit code 1.

Update: issue about this: #987

@lmolkova lmolkova mentioned this pull request May 1, 2024
Closed
trask
trask reviewed May 1, 2024
View reviewed changes
Comment thread model/metrics/deprecated/database.yaml Outdated
@trask trask mentioned this pull request May 1, 2024
Closed
3 tasks
@lmolkova lmolkova merged commit 70baddd into open-telemetry:main May 2, 2024
drewby pushed a commit to drewby/otel-semantic-conventions that referenced this pull request May 23, 2024
@gregkalapos @drewby
Rename db.client.connections.* metrics to db.client.connection.* …
635b5e0 
…and rename `db.client.connection.usage` to `db.client.connection.count` and adapting units (open-telemetry#966)

Co-authored-by: Liudmila Molkova <[email protected]>
@trask trask mentioned this pull request Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsuereth jsuereth jsuereth left review comments

@trask trask trask approved these changes

@lmolkova lmolkova lmolkova approved these changes

@trisch-me trisch-me trisch-me left review comments

@pyohannes pyohannes pyohannes left review comments

Assignees

@AlexanderWert AlexanderWert

Labels

None yet

Projects

Semantic Conventions Triage
Archived in project
Database Client Semantic Conventions
Status: Done

Milestone

No milestone

7 participants

@gregkalapos @jsuereth @trask @lmolkova @trisch-me @pyohannes @AlexanderWert