Skip to content

LLM Semantic Conventions: Initial PR#825

Merged
lmolkova merged 47 commits intoopen-telemetry:mainfrom
traceloop:first-gen-ai
Apr 16, 2024
Merged

LLM Semantic Conventions: Initial PR#825
lmolkova merged 47 commits intoopen-telemetry:mainfrom
traceloop:first-gen-ai

Conversation

@nirga
Copy link
Copy Markdown
Contributor

@nirga nirga commented Mar 19, 2024

Work towards #327.

Changes

Replacing PRs #639 and #483. Introduces semantic conventions for modern AI systems, following discussions in OpenTelemetry LLM semconv working group.

Merge requirement checklist

@nirga nirga requested review from a team March 19, 2024 11:46
@nirga nirga mentioned this pull request Mar 19, 2024
3 tasks
Comment thread docs/attributes-registry/llm.md Outdated
@nirga nirga force-pushed the first-gen-ai branch 2 times, most recently from 81ed4a4 to b642c4c Compare March 20, 2024 14:12
Comment thread docs/attributes-registry/gen-ai.md Outdated
Comment thread docs/attributes-registry/gen-ai.md Outdated
Copy link
Copy Markdown

@iag iag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this initial revision!

Comment thread docs/attributes-registry/llm.md
Comment thread docs/gen-ai/llm-spans.md Outdated
Comment thread docs/gen-ai/llm-spans.md
Co-authored-by: Liudmila Molkova <[email protected]>
Copy link
Copy Markdown
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the issues that I had raised earlier.

Comment thread model/registry/gen-ai.yaml
Comment thread docs/attributes-registry/llm.md
Comment thread .chloggen/first-gen-ai.yaml Outdated
Comment thread docs/gen-ai/llm-spans.md
Comment thread docs/attributes-registry/llm.md
@joaopgrassi
Copy link
Copy Markdown
Member

@nirga are you able to fix the conflicts? I think this looks good to merge :)

@nirga
Copy link
Copy Markdown
Contributor Author

nirga commented Apr 16, 2024

Thanks @joaopgrassi! I've resolved all the comments and fixed the conflicts. I think we're good to go :)

Copy link
Copy Markdown
Member

@alolita alolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm.

A call out I have is that while we specifically only mention LLMs - ML models have been around for a long time - so isn't model observability including LLMs what we want to address with these semantic conventions? Lets discuss in our weekly SIG meeting.

@cartermp
Copy link
Copy Markdown
Contributor

FWIW my take is that scoping to LLMs for now is still the right call, but we should absolutely not design for only them (and I believe that's not happeing). Even in this space, there's multi-modality, language models (like embedding models) that aren't about generating text, diffusion models, etc.

The good news is that a lot of the fundamentals around capturing data for various purposes are likely to be similar across many different models types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.