Clarify metric attributes should be namespaced#786
Merged
arminru merged 15 commits intoopen-telemetry:mainfrom Mar 8, 2024
Merged
Clarify metric attributes should be namespaced#786arminru merged 15 commits intoopen-telemetry:mainfrom
arminru merged 15 commits intoopen-telemetry:mainfrom
Conversation
joaopgrassi
changed the title
2 tasks
arminru
approved these changes
Feb 29, 2024
Member
arminru
left a comment
arminru
left a comment
There was a problem hiding this comment.
LGTM!
I think this would still be worth an entry in the changelog to make others aware.
trask
approved these changes
Feb 29, 2024
jack-berg
reviewed
Feb 29, 2024
lmolkova
reviewed
Mar 1, 2024
joaopgrassi
changed the title
joaopgrassi
changed the title
joaopgrassi
changed the title
ChrsMark
reviewed
Mar 4, 2024
ChrsMark
approved these changes
Mar 4, 2024
Member
Author
lmolkova
approved these changes
Mar 6, 2024
Member
lmolkova
left a comment
lmolkova
left a comment
There was a problem hiding this comment.
Left a comment on must vs should, but looks great otherwise
trask
reviewed
Mar 6, 2024
Co-authored-by: Liudmila Molkova <[email protected]>
ChrsMark
approved these changes
Mar 7, 2024
pyohannes
approved these changes
Mar 7, 2024
Co-authored-by: Chris Mark <[email protected]>
arminru
approved these changes
Mar 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #394
Changes
Adds a section on the general metric guidelines about attributes. Specifically, calling out the TC decision about metric attributes being required to be namespaced.
Merge requirement checklist
[chore]