[chore] revert temp fix for resource attributes#702
Merged
joaopgrassi merged 8 commits intoopen-telemetry:mainfrom Feb 12, 2024
Merged
[chore] revert temp fix for resource attributes#702joaopgrassi merged 8 commits intoopen-telemetry:mainfrom
joaopgrassi merged 8 commits intoopen-telemetry:mainfrom
Conversation
2 tasks
joaopgrassi
reviewed
Feb 8, 2024
joaopgrassi
approved these changes
Feb 9, 2024
…ntions into revert_resource
trisch-me
changed the title
AlexanderWert
approved these changes
Feb 12, 2024
ChrsMark
pushed a commit
to ChrsMark/semantic-conventions
that referenced
this pull request
Feb 21, 2024
Co-authored-by: Joao Grassi <[email protected]> Co-authored-by: Josh Suereth <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #524
Changes
As the fix in open-telemetry/build-tools#243 was merged we can revert type of attributes in global registry to be just
attribute_groupand notresource.Merge requirement checklist
[chore]