Temp fix for separation of resource and semantic attributes#524
Merged
jsuereth merged 3 commits intoopen-telemetry:mainfrom Nov 16, 2023
Merged
Temp fix for separation of resource and semantic attributes#524jsuereth merged 3 commits intoopen-telemetry:mainfrom
jsuereth merged 3 commits intoopen-telemetry:mainfrom
Conversation
…istry Signed-off-by: Alexander Wert <[email protected]>
ChrsMark
approved these changes
Nov 15, 2023
Member
ChrsMark
left a comment
ChrsMark
left a comment
There was a problem hiding this comment.
The change looks good to me.
Do we have additional information of where it was spotted and any additional background?
Also would that worth it to somehow document the valid types? Maybe in the registry's README?
Member
Author
On more details see the slack channel #otel-semantic-conventions-wg . This is just a temporary fix, but we need a cleaner solution long term. |
joaopgrassi
approved these changes
Nov 15, 2023
jsuereth
approved these changes
Nov 16, 2023
arminru
pushed a commit
to dynatrace-oss-contrib/semantic-conventions
that referenced
this pull request
Nov 17, 2023
…emetry#524) Signed-off-by: Alexander Wert <[email protected]> Co-authored-by: Josh Suereth <[email protected]> (cherry picked from commit 2817a7f)
arminru
added a commit
that referenced
this pull request
Nov 17, 2023
… attributes (#524) (#537) Co-authored-by: Alexander Wert <[email protected]>
3 tasks
pyohannes
pushed a commit
to pyohannes/semantic-conventions
that referenced
this pull request
Jan 17, 2024
…emetry#524) Signed-off-by: Alexander Wert <[email protected]> Co-authored-by: Josh Suereth <[email protected]>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes broken code generation that assumes that resource attributes are strictly separated from semantic attributes.
Merge requirement checklist
CHANGELOG.md updated for non-trivial changes.schema-next.yaml updated with changes to existing conventions.