[host] update the recommendations to use full paths to commands#3896
Merged
lmolkova merged 4 commits intoJul 23, 2026
Conversation
martincostello
approved these changes
Jul 15, 2026
ysolomchenko
approved these changes
Jul 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Host resource documentation to recommend using full filesystem paths when invoking system commands to retrieve machine identifiers, improving clarity and reducing ambiguity in command resolution.
Changes:
- Use
/bin/kenv(instead ofkenv) for the BSD fallback machine ID lookup command. - Use
/usr/sbin/ioreg(instead ofioreg) for the macOS primary machine ID lookup command.
pellared
approved these changes
Jul 15, 2026
pellared
left a comment
pellared
left a comment
Member
There was a problem hiding this comment.
Please update the PR description.
Please describe the reason behind the change and link some implementation PRs.
lmolkova
approved these changes
Jul 17, 2026
github-project-automation
Bot
moved this from Untriaged
to Needs More Approval
in Semantic Conventions Triage
lmolkova
moved this from Needs More Approval
to Awaiting codeowners approval
in Semantic Conventions Triage
lmolkova
reviewed
Jul 17, 2026
braydonk
approved these changes
Jul 17, 2026
lmolkova
moved this from Awaiting codeowners approval
to Ready to be Merged
in Semantic Conventions Triage
Pull request dashboard statusStatus last refreshed: 2026-07-23 03:24:52 UTC.
This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected. |
Member
Context is the now-published GHSA-v8pv-4842-x354. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes
Update the recommendations to use full path to commands.
Recommendation is based on the implementation in
opentelemetry-gowhich was recently fixed.Important
Pull request acceptance is subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above may be automatically rejected and closed.
Merge requirement checklist
Footnotes
Yes, I can answer maintainer questions about the content of this PR without using AI. ↩