Add shared zizmor workflow#3895
Merged
lmolkova merged 6 commits intoJul 17, 2026
Merged
Conversation
14 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Adds repository-wide GitHub Actions security scanning via the OpenTelemetry shared Zizmor reusable workflow, and hardens several existing workflows to reduce credential persistence and potential injection surfaces.
Changes:
- Add a new
.github/workflows/zizmor.ymlworkflow that runs Zizmor on PRs, pushes tomain, and a weekly schedule, uploading SARIF to code scanning. - Update multiple workflows to set
actions/checkoutpersist-credentials: false. - Refactor several workflow
run:steps to pass GitHub context/step outputs viaenv:variables (and adjust PR-creation flows to use explicit tokens/permissions).
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/zizmor.yml | Adds the shared-workflow-based Zizmor scan with SARIF upload permissions. |
| .github/workflows/validate-prerelease.yml | Disables persisted checkout credentials; moves release tag usage into env. |
| .github/workflows/reusable-workflow-notification.yml | Disables persisted checkout credentials. |
| .github/workflows/reusable-link-check.yml | Disables persisted checkout credentials; refactors base ref / modified-files argument passing. |
| .github/workflows/prepare-release.yml | Disables persisted checkout credentials; moves inputs into env; adjusts PR creation/push auth and app token permissions. |
| .github/workflows/prepare-new-pr.yml | Adds zizmor rule suppression note; disables persisted checkout credentials. |
| .github/workflows/prepare-new-issue.yml | Disables persisted checkout credentials. |
| .github/workflows/post-release.yml | Disables persisted checkout credentials; moves release tag / step output usage into env; adjusts PR creation/push auth and app token permissions. |
| .github/workflows/podman-check.yml | Disables persisted checkout credentials. |
| .github/workflows/generate-registry-area-labels.yml | Disables persisted checkout credentials. |
| .github/workflows/fossa.yml | Disables persisted checkout credentials. |
| .github/workflows/checks.yml | Disables persisted checkout credentials across multiple jobs. |
| .github/workflows/check-changes-ownership.yml | Adds zizmor rule suppression note; disables persisted checkout credentials for base-branch checkout. |
| .github/workflows/changelog.yml | Disables persisted checkout credentials. |
| .github/workflows/auto-update-spec-repo-links.yml | Disables persisted checkout credentials; adjusts PR creation/push auth and app token permissions. |
trask
approved these changes
Jul 15, 2026
lmolkova
approved these changes
Jul 17, 2026
github-project-automation
Bot
moved this from Untriaged
to Needs More Approval
in Semantic Conventions Triage
Merged
via the queue into
open-telemetry:main
with commit Jul 17, 2026
a6ae90f
17 of 18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked in open-telemetry/sig-security#293.
Adds zizmor scanning through the OpenTelemetry shared workflow.
The workflow:
regularpersona on pull requests, pushes tomain, and a randomized weekly schedule;Zizmor remediation
This change also resolves findings from these zizmor rules:
artipackeddangerous-triggersgithub-apptemplate-injectionAfter merge
zizmorcode-scanning result.If enforcement unexpectedly blocks a valid change, restore
require_zizmor = falseinopen-telemetry/adminwhile leaving scanning enabled.