BREAKING: Use seconds as default duration for FaaS duration histograms#384
Merged
AlexanderWert merged 8 commits intoopen-telemetry:mainfrom Oct 24, 2023
Merged
Conversation
pyohannes
changed the title
lmolkova
approved these changes
Oct 11, 2023
tylerbenson
approved these changes
Oct 12, 2023
trask
approved these changes
Oct 12, 2023
jsuereth
approved these changes
Oct 19, 2023
Contributor
jsuereth
left a comment
jsuereth
left a comment
There was a problem hiding this comment.
Approving this under the assumption that these semconv aren't used heavily and this breaking change won't actually affect any (or not many) users.
Contributor
|
@pyohannes Can you open a bug against the specification asking for SCHEMA files to allow us to denote BREAKING changes where a metric changes its unit? EDIT: Also, FYI - I check your schema_url mark. When Schema URL cannot express a breaking change, at this point we should open a collection of bugs for schema-url improvements. |
Contributor
Author
|
joaopgrassi
approved these changes
Oct 23, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #382
Changes
General guidelines for metric instrumentation units require that for measuring durations, seconds should be used:
This PR brings the FaaS metrics
faas.invoke_duration,faas.init_duration, andfaas.cpu.usagein line with this requirement.As I couldn't find a place where those metrics are currently implemented or used, this change is proposed without recourse to any compatibility mechanism.
Merge requirement checklist