Skip to content

error.type and exception.type MAY unwrap uninformative wrapper types#3623

Merged
lmolkova merged 6 commits intoopen-telemetry:mainfrom
pellared:unwrap-exceptions
Apr 22, 2026
Merged

error.type and exception.type MAY unwrap uninformative wrapper types#3623
lmolkova merged 6 commits intoopen-telemetry:mainfrom
pellared:unwrap-exceptions

Conversation

@pellared
Copy link
Copy Markdown
Member

@pellared pellared commented Apr 14, 2026 •
edited
Loading

Fixes #3588

OTel Go SDK implementation:

OTel Java instrumenter API implementation:

Changes

Please provide a brief description of the changes here.

Important

Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

@pellared pellared marked this pull request as ready for review April 14, 2026 17:42
@pellared pellared requested review from a team as code owners April 14, 2026 17:42
@github-actions

This comment was marked as spam.

Sign in to view
@github-actions github-actions Bot closed this Apr 14, 2026
@github-actions

This comment was marked as spam.

Sign in to view
7 similar comments
@github-actions

This comment was marked as spam.

Sign in to view
@github-actions

This comment was marked as spam.

Sign in to view
@github-actions

This comment was marked as spam.

Sign in to view
@github-actions

This comment was marked as spam.

Sign in to view
@github-actions

This comment was marked as spam.

Sign in to view
@github-actions

This comment was marked as spam.

Sign in to view
@github-actions

This comment was marked as spam.

Sign in to view
@pellared pellared reopened this Apr 14, 2026
lmolkova
lmolkova approved these changes Apr 21, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicking, but looks great!

Comment thread model/exceptions/registry.yaml Outdated
Comment thread model/error/registry.yaml Outdated
@pellared pellared requested a review from joaopgrassi April 21, 2026 17:51
@lmolkova lmolkova added this pull request to the merge queue Apr 22, 2026
Merged via the queue into open-telemetry:main with commit b4ea919 Apr 22, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmolkova lmolkova lmolkova approved these changes

@joaopgrassi joaopgrassi Awaiting requested review from joaopgrassi

+1 more reviewer

@alexmojaki alexmojaki alexmojaki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:error area:exception enhancement New feature or request triage:accepted:ready

Projects

Semantic Conventions Triage
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Exception / error.type: suggest unwrapping 'junk' exceptions

4 participants

@pellared @lmolkova @alexmojaki @joaopgrassi