Add k8s.node.system_container.* metrics#3556
Merged
jsuereth merged 12 commits intoopen-telemetry:mainfrom Apr 15, 2026
Merged
Conversation
PlateauGao
force-pushed
the
feat/k8s-node-system-container-metrics
branch
from
7f23391 to
a53e042
Compare
PlateauGao
force-pushed
the
feat/k8s-node-system-container-metrics
branch
from
e5fc292 to
fc8eddf
Compare
ChrsMark
reviewed
Mar 18, 2026
PlateauGao
force-pushed
the
feat/k8s-node-system-container-metrics
branch
from
42ad719 to
fc8eddf
Compare
ChrsMark
reviewed
Mar 19, 2026
ChrsMark
approved these changes
Mar 19, 2026
Contributor
Author
|
Hi @dashpole , I wonder if you could please take another look at this PR? Thanks! |
dashpole
reviewed
Mar 23, 2026
dashpole
approved these changes
Mar 23, 2026
jinja2
reviewed
Mar 23, 2026
Contributor
Author
|
Hi @ChrsMark, I wonder what the process would be? I wonder if we need to wait for an approver and maintainer? Or I can try to reach out to one maintainer |
Contributor
Author
|
Hi @jinja2, I wonder if you could please take another took and let me know if there is any other question? I think I need to have all comments resolved to get maintainer approval. Thanks! |
dmitryax
approved these changes
Apr 8, 2026
jinja2
approved these changes
Apr 8, 2026
dashpole
added
the
ready-to-merge
kamphaus
approved these changes
Apr 11, 2026
kamphaus
reviewed
Apr 13, 2026
github-project-automation
Bot
moved this from Ready to be Merged
to Needs More Approval
in Semantic Conventions Triage
Contributor
Author
|
Looks we need one more approval from open-telemetry/specs-semconv-maintainers? |
jsuereth
approved these changes
Apr 15, 2026
jsuereth
moved this from Needs More Approval
to Ready to be Merged
in Semantic Conventions Triage
ChrsMark
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Apr 30, 2026
…age`, `memory.working_set`) to the `kubeletstats` receiver (#47775) #### Description Adding a feature - Added 3 new optional metrics for system containers (`cpu.time`, `cpu.usage`, `memory.working_set`) to the `kubeletstats` receiver to capture node-level system daemon metrics as proposed in semantic conventions. These metrics represent cgroup-level resource trackers on the node that are not associated with any k8s Pod (e.g., kubelet, runtime). #### Link to tracking issue - Relates to Semantic Conventions Issue: open-telemetry/semantic-conventions#3531 - Relates to Semantic Conventions PR: open-telemetry/semantic-conventions#3556 #### Testing - Added `TestScraperWithSystemContainerMetrics` in `scraper_test.go` to verify the new metrics are collected correctly when enabled. - Verified that all tests pass in the `kubeletstatsreceiver` directory. - Updated golden files for existing tests to reflect the new default state (metrics disabled). #### Documentation - Updated `metadata.yaml` and regenerated `documentation.md` using `mdatagen`. The new metrics are listed in the "Optional Metrics" section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3531
Changes
Add k8s.node.system_container.* metrics and a self describing attribute k8s.node.system_container.name to capture node-level system daemon metrics." Please refer to the issue for detailed proposal
Important
Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.
Merge requirement checklist
[chore]