Skip to content

Move process executable to its own entity#3536

Merged
jsuereth merged 12 commits intoopen-telemetry:mainfrom
osullivandonal:move-process-executable-to-its-own-entity
Apr 23, 2026
Merged

Move process executable to its own entity#3536
jsuereth merged 12 commits intoopen-telemetry:mainfrom
osullivandonal:move-process-executable-to-its-own-entity

Conversation

@osullivandonal
Copy link
Copy Markdown
Contributor

@osullivandonal osullivandonal commented Mar 11, 2026

Fixes #3535

Changes

Move process.executable to its own entity
This is being done as per feedback from updating the process attributes
requirement levels work, see PR: #3461.

The advantage to moving process.executable to
its own entity to to allow a relationship between process and
process.executable, for example you could look at all processes belonging
to a single executable.

The new identifying attributes for the new entity process.executable are:

  • process.executable.name
  • process.executable.path

Important

Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

@osullivandonal
Move process.executable to its own entity
f6649f5 
This is being done as per feedback from updating the process attributes
requirement levels work.The advantage to moving process.executable to
its own entity to to allow a relationship between process and
process.executable, for example you could look at all processes beloning
to a single executable.
@osullivandonal
Update process.executable brief
a204c60
@osullivandonal
Add chlog for moving process.executable to its own entity
6db49e4
@osullivandonal osullivandonal requested review from a team as code owners March 11, 2026 11:52
thompson-tomo
thompson-tomo reviewed Mar 12, 2026
View reviewed changes
Comment thread model/process/entities.yaml Outdated
Comment thread model/process/entities.yaml
thompson-tomo
thompson-tomo reviewed Mar 16, 2026
View reviewed changes
Comment thread model/process/entities.yaml
@osullivandonal
Ran make registry-generation
de94b3e
@osullivandonal
Update process.executable attributes
79b9721 
Added build_id.go and build_id.gnu, build_id.htlhash
thompson-tomo
thompson-tomo approved these changes Mar 19, 2026
View reviewed changes
Comment thread .chloggen/move-process-executable-to-its-own-entity.yaml
@osullivandonal osullivandonal force-pushed the move-process-executable-to-its-own-entity branch 2 times, most recently from 01a1e0e to f17cec7 Compare March 19, 2026 16:43
ChrsMark
ChrsMark approved these changes Mar 19, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Let's file an issue for #3536 (comment) so we don't miss that.

@osullivandonal osullivandonal mentioned this pull request Mar 20, 2026
Closed
@osullivandonal
Copy link
Copy Markdown
Contributor Author

osullivandonal commented Mar 20, 2026

LGTM

Let's file an issue for #3536 (comment) so we don't miss that.

New issue created #3563

@ChrsMark ChrsMark moved this from Untriaged to Ready to be Merged in Semantic Conventions Triage Mar 22, 2026
lmolkova
lmolkova approved these changes Mar 27, 2026
View reviewed changes
Comment thread model/process/entities.yaml
braydonk
braydonk requested changes Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@braydonk braydonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually don't press the "Request Changes" button cause it feels aggressive lol, just doing it here because my comment is intended to block merge.

Comment thread model/process/entities.yaml
@github-project-automation github-project-automation Bot moved this from Ready to be Merged to Blocked in Semantic Conventions Triage Mar 27, 2026
braydonk
braydonk reviewed Apr 9, 2026
View reviewed changes
Comment thread model/process/entities.yaml
@mx-psi mx-psi moved this from Blocked to Ready to be Merged in Semantic Conventions Triage Apr 9, 2026
@mx-psi
Copy link
Copy Markdown
Member

mx-psi commented Apr 9, 2026

@open-telemetry/specs-semconv-maintainers this is ready to be merged from the System SemConv SIG side :)

@braydonk braydonk mentioned this pull request Apr 9, 2026
Open
3 tasks
@trask
Copy link
Copy Markdown
Member

trask commented Apr 13, 2026

@open-telemetry/specs-semconv-maintainers this is ready to be merged from the System SemConv SIG side :)

it looks like there are still a couple of open conversations

@mx-psi
Copy link
Copy Markdown
Member

mx-psi commented Apr 13, 2026

@braydonk could you review the conversations and close them if it makes sense?

@trask
Copy link
Copy Markdown
Member

trask commented Apr 20, 2026

@braydonk could you review the conversations and close them if it makes sense?

cc @braydonk

@braydonk
Copy link
Copy Markdown
Contributor

braydonk commented Apr 20, 2026

@trask @mx-psi I believe I have resolved the last open thread of conversation.

@trask trask added this pull request to the merge queue Apr 20, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 20, 2026
@mx-psi
Copy link
Copy Markdown
Member

mx-psi commented Apr 21, 2026

Looks like this needs make registry-generation. @osullivandonal could you take a look?

@osullivandonal
Copy link
Copy Markdown
Contributor Author

osullivandonal commented Apr 21, 2026 •
edited
Loading

Looks like this needs make registry-generation. @osullivandonal could you take a look?

This is done now, I merged with main and ran make registry-generation. Could we try to merge again? @mx-psi @trask

@github-project-automation github-project-automation Bot moved this from Ready to be Merged to Needs More Approval in Semantic Conventions Triage Apr 23, 2026
@jsuereth jsuereth added this pull request to the merge queue Apr 23, 2026
Merged via the queue into open-telemetry:main with commit 46da304 Apr 23, 2026
18 checks passed
@osullivandonal osullivandonal deleted the move-process-executable-to-its-own-entity branch April 23, 2026 12:53
@thompson-tomo thompson-tomo mentioned this pull request Apr 30, 2026
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@braydonk braydonk braydonk approved these changes

@jsuereth jsuereth jsuereth approved these changes

@florianl florianl florianl approved these changes

@lmolkova lmolkova lmolkova approved these changes

@mx-psi mx-psi mx-psi approved these changes

@ChrsMark ChrsMark ChrsMark approved these changes

@rogercoll rogercoll rogercoll approved these changes

@christos68k christos68k christos68k approved these changes

+1 more reviewer

@thompson-tomo thompson-tomo thompson-tomo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:process breaking

Projects

Semantic Conventions Triage
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move process.executable to its own entity