Skip to content

Rename system.memory.shared to system.memory.linux.shared#3263

Merged
lmolkova merged 5 commits intoopen-telemetry:mainfrom
osullivandonal:rename-system-memory-shared
Jan 15, 2026
Merged

Rename system.memory.shared to system.memory.linux.shared#3263
lmolkova merged 5 commits intoopen-telemetry:mainfrom
osullivandonal:rename-system-memory-shared

Conversation

@osullivandonal
Copy link
Copy Markdown
Contributor

@osullivandonal osullivandonal commented Jan 9, 2026

Fixes #3260

Changes

This aligns the shared memory metric with other Linux-specific memory metrics (system.memory.linux.available and system.memory.linux.slab.usage)

There is an open PR in collector-contrib in hostmetricsreceiver (see here) to add the system metric system.memory.shared, and since this is a Linux specific metric, the feedback has been to update the semconv to align with other Linux specific metrics.

Since this semconv has not been implemented yet, it was decided to not mark system.memory.shared as deprecated.

Important

Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

@osullivandonal
Rename system.memory.shared to system.memory.linux.shared
dc4c84b 
This aligns the shared memory metric with other Linux-specific memory
metrics (system.memory.linux.available and system.memory.linux.slab.usage)

Fixes open-telemetry#3260
@osullivandonal osullivandonal requested review from a team as code owners January 9, 2026 09:45
@osullivandonal osullivandonal mentioned this pull request Jan 9, 2026
Merged
ChrsMark
ChrsMark reviewed Jan 9, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good based on the relevant guidance: https://github.com/open-telemetry/semantic-conventions/blob/main/docs/non-normative/groups/system/design-philosophy.md#operating-system-in-names

Left one comment about the deprecation of the replaced metric.

Comment thread model/system/metrics.yaml
@lmolkova lmolkova moved this from Untriaged to Awaiting codeowners approval in Semantic Conventions Triage Jan 10, 2026
ChrsMark
ChrsMark reviewed Jan 12, 2026
View reviewed changes
Comment thread model/system/deprecated/metrics-deprecated.yaml Outdated
@kamphaus
Copy link
Copy Markdown
Contributor

kamphaus commented Jan 12, 2026

This PR aligns with the PR discussion: open-telemetry/opentelemetry-collector-contrib#45194 (comment)
and what braydonk proposes in

Should we wait for #3261 to be merged or can this PR proceed already?

@osullivandonal osullivandonal mentioned this pull request Jan 13, 2026
Closed
6 tasks
@osullivandonal
Copy link
Copy Markdown
Contributor Author

osullivandonal commented Jan 14, 2026

This PR aligns with the PR discussion: open-telemetry/opentelemetry-collector-contrib#45194 (comment) and what braydonk proposes in

Should we wait for #3261 to be merged or can this PR proceed already?

There are already semconv for other linux specific metrics under system.memory.linux.* at model/system/metrics.yaml such as:

Given that do we need to wait for #3261 ?

@lmolkova lmolkova moved this from Awaiting codeowners approval to Needs More Approval in Semantic Conventions Triage Jan 14, 2026
@lmolkova lmolkova moved this from Needs More Approval to Ready to be Merged in Semantic Conventions Triage Jan 14, 2026
@github-project-automation github-project-automation Bot moved this from Ready to be Merged to Needs More Approval in Semantic Conventions Triage Jan 14, 2026
@kamphaus kamphaus moved this from Needs More Approval to Ready to be Merged in Semantic Conventions Triage Jan 14, 2026
@lmolkova lmolkova added this pull request to the merge queue Jan 15, 2026
Merged via the queue into open-telemetry:main with commit cd50e99 Jan 15, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmolkova lmolkova lmolkova approved these changes

@kamphaus kamphaus kamphaus approved these changes

@ChrsMark ChrsMark ChrsMark approved these changes

@rogercoll rogercoll rogercoll approved these changes

Assignees

No one assigned

Labels

area:system breaking

Projects

Semantic Conventions Triage
Archived in project
System Semantic Convention Working Group
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rename system.memory.shared to system.memory.linux.shared

5 participants

@osullivandonal @kamphaus @lmolkova @ChrsMark @rogercoll