Skip to content

Stabilize service.instance.id attribute#3253

Merged
jsuereth merged 10 commits intoopen-telemetry:mainfrom
Arnav-Bansal:stabilize-service-instance-id
Feb 3, 2026
Merged

Stabilize service.instance.id attribute#3253
jsuereth merged 10 commits intoopen-telemetry:mainfrom
Arnav-Bansal:stabilize-service-instance-id

Conversation

@Arnav-Bansal
Copy link
Copy Markdown
Contributor

@Arnav-Bansal Arnav-Bansal commented Jan 7, 2026

Changes

Closes #1519

This PR marks service.instance.id attribute as stable

Important

Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.

Merge requirement checklist

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Jan 7, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Arnav-Bansal / name: Arnav (780a954)

@github-actions github-actions Bot added enhancement New feature or request area:service labels Jan 7, 2026
@Arnav-Bansal Arnav-Bansal changed the base branch from main to release/v1.23.x January 7, 2026 10:30
@Arnav-Bansal Arnav-Bansal changed the base branch from release/v1.23.x to main January 7, 2026 10:30
@Arnav-Bansal Arnav-Bansal force-pushed the stabilize-service-instance-id branch from 1617754 to 4ff951a Compare January 7, 2026 10:35
@Arnav-Bansal Arnav-Bansal marked this pull request as ready for review January 12, 2026 06:55
@Arnav-Bansal Arnav-Bansal requested review from a team as code owners January 12, 2026 06:55
Comment thread model/service/registry.yaml
@lmolkova lmolkova moved this from Untriaged to Awaiting codeowners approval in Semantic Conventions Triage Jan 13, 2026
Copy link
Copy Markdown
Contributor

@thompson-tomo thompson-tomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to regenerate the docs so that the entity definition in the docs is updated.

Comment thread docs/resource/service.md Outdated
Copy link
Copy Markdown

@janhvi31 janhvi31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Arnav-Bansal Arnav-Bansal force-pushed the stabilize-service-instance-id branch from 09e859c to 213136f Compare February 2, 2026 09:46
@joaopgrassi joaopgrassi moved this from Awaiting codeowners approval to Ready to be Merged in Semantic Conventions Triage Feb 2, 2026
@joaopgrassi
Copy link
Copy Markdown
Member

Do we want to resolve these before merging this one? #1519 (comment)

I'm on the opinion that not, but just to be sure everyone is aware of them.

@jsuereth
Copy link
Copy Markdown
Contributor

jsuereth commented Feb 2, 2026

@joaopgrassi I made a comment on the bug. PTAL - I think we need to change sequencing of the original assumption given our new stable-by-default goals for distributions. As such, I think service.instance.id in semconv is ok to stabilize.

@joaopgrassi
Copy link
Copy Markdown
Member

@jsuereth sounds good to me! We are ready to go here.

@jsuereth jsuereth added this pull request to the merge queue Feb 3, 2026
Merged via the queue into open-telemetry:main with commit ecd7e1e Feb 3, 2026
18 checks passed
@Arnav-Bansal Arnav-Bansal deleted the stabilize-service-instance-id branch February 3, 2026 14:37
bidetofevil pushed a commit to bidetofevil/semantic-conventions that referenced this pull request Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:service enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Stabilize service.instance.id since it's populated in stable OTel SDKs

10 participants