Mark sampling-relevant attributes on RPC spans#3203
Merged
lmolkova merged 2 commits intoopen-telemetry:mainfrom Dec 15, 2025
Merged
Mark sampling-relevant attributes on RPC spans#3203lmolkova merged 2 commits intoopen-telemetry:mainfrom
lmolkova merged 2 commits intoopen-telemetry:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR marks sampling-relevant attributes on RPC spans to indicate which attributes should be provided at span creation time for making sampling decisions. The changes address issue #3202 by adding sampling_relevant: true flags in the YAML model for key RPC attributes.
Key changes:
- Marks
rpc.system.name,rpc.method,rpc.service,server.address, andserver.portas sampling-relevant in the RPC YAML model - Updates documentation to include guidance that these attributes "can be important for making sampling decisions and SHOULD be provided at span creation time"
- Applies changes consistently across generic RPC, gRPC, Connect RPC, and JSON-RPC span types
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| model/rpc/spans.yaml | Adds sampling_relevant flags to RPC attributes in the YAML model for various span types |
| docs/rpc/rpc-spans.md | Adds documentation sections listing sampling-relevant attributes for generic RPC client and server spans |
| docs/rpc/json-rpc.md | Adds documentation sections listing sampling-relevant attributes for JSON-RPC client and server spans |
| docs/rpc/grpc.md | Adds documentation sections listing sampling-relevant attributes for gRPC client and server spans |
| docs/rpc/connect-rpc.md | Adds documentation sections listing sampling-relevant attributes for Connect RPC client and server spans |
| .chloggen/rpc-sampling.yaml | Adds changelog entry documenting the enhancement |
lmolkova
moved this from Untriaged
to Awaiting codeowners approval
in Semantic Conventions Triage
trask
approved these changes
Dec 15, 2025
lmolkova
moved this from Awaiting codeowners approval
to Needs More Approval
in Semantic Conventions Triage
matt-hensley
approved these changes
Dec 15, 2025
github-project-automation
Bot
moved this from In Progress
to Done
in RPC Semantic Conventions Stability
Cirilla-zmh
pushed a commit
to Cirilla-zmh/semantic-conventions
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3202