Remove the zero bucket boundary from http.server.request.duration and http.client.request.duration#318
Merged
reyang merged 4 commits intoopen-telemetry:mainfrom Sep 26, 2023
Conversation
`http.client.request.duration`
trask
force-pushed
the
http-duration-buckets
branch
from
2774c81 to
8d189c5
Compare
mateuszrzeszutek
approved these changes
Sep 15, 2023
lmolkova
approved these changes
Sep 26, 2023
jack-berg
approved these changes
Sep 26, 2023
MrAlias
approved these changes
Sep 26, 2023
joaopgrassi
approved these changes
Sep 26, 2023
jmacd
approved these changes
Sep 26, 2023
Contributor
|
After this change, it's odd that the default buckets - https://github.com/open-telemetry/opentelemetry-specification/blob/7a7b36e88742f834c1097cc7f1c1d13182cb1142/specification/metrics/sdk.md#explicit-bucket-histogram-aggregation - have zero, and this one doesn't. Also, the number of buckets is now inconsistent between these durations and the defaults. It was easy to reason that these buckets were simply the defaults but adjusted to seconds. |
Member
Author
|
my interpretation of the default buckets is that they are (sadly) just a legacy artifact, and are pretty meaningless now that the default unit has changed to seconds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #298
Changes
Removes the zero bucket boundary from
http.server.request.durationandhttp.client.request.duration.Merge requirement checklist
schema-next.yaml updated with changes to existing conventions.