Add oracle_cloud.realm vendor attribute#3124
Conversation
|
This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:
Such changes may be rejected or put on hold until a new SIG/project is established. Please refer to the Semantic Convention Areas |
|
cc @dashpole . Not sure what to do about the above error. Do we need to start a new SIG/project? |
|
@jsuereth I Don't see a SIG/project associated with most cloud providers. How can we add oracle-cloud? Do we need a new SIG? |
|
Paused, pending creation of |
|
@geekdave thoughts on having the attribute named Also it might be a good idea to associate the new attribute with an entity. Based on https://opentelemetry.io/docs/specs/semconv/how-to-write-conventions/resource-and-entities/#when-to-define-an-is-a-relationship-vs-extending-descriptive-attributes my suggestion would be to extend the existing cloud entity with the additional attribute as i don't see us generating metrics specific to an Oracle cloud location which doesn't apply to all cloud locations. For this |
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 7 days. |
|
Closing and re-opening to see if it picks up new CODEOWNERS |
|
@thompson-tomo thanks for the suggestion! I attended the semconf SIG meeting via Zoom this morning and we discussed this topic. The consensus was that it's OK to leave |
Fixes #3121
Changes
Add
oracle_cloud.realmvendor-specific attribute for Oracle Cloud Infrastructure (OCI)realmidentifier.Note
This will be used in the already-created Oracle Cloud resource detection processor, part of the collector-contrib project. See: open-telemetry/opentelemetry-collector-contrib#44408
I went back and forth about whether this
realmattribute should be placed at:a) the root of the vendor-prefixed hierarchy such as
oracle_cloud.realmorb) in service-specific properties like
oracle_cloud.oracle_cloud_oke.realmandoracle_cloud.oracle_cloud_compute.realmI asked about this in
#otel-semantic-conventionsand got this feedback from @thompson-tomo :I am open to more feedback on this. But realm is a concept that applies to nearly all OCI services, so I think it makes sense to place it at the root.
Merge requirement checklist
[chore]