Skip to content

feat: introduce new service.criticality attribute (#2986)#3088

Merged
lmolkova merged 2 commits intoopen-telemetry:mainfrom
bachgarash:feat/service-criticality-attribute
Jan 23, 2026
Merged

feat: introduce new service.criticality attribute (#2986)#3088
lmolkova merged 2 commits intoopen-telemetry:mainfrom
bachgarash:feat/service-criticality-attribute

Conversation

@bachgarash
Copy link
Copy Markdown
Contributor

@bachgarash bachgarash commented Nov 14, 2025 •
edited
Loading

Fixes #2986

This PR introduces a new attribute - service.criticality

Relevant discussion has been made during Service and Deployment Semconv SIG meet

Meet notes https://docs.google.com/document/d/1Fy6yXfZqrwN_oHw95Bdfg_0hzUgzlk3VO5wA1invgkI/edit?tab=t.0

Recording can be found https://docs.google.com/spreadsheets/d/1SYKfjYhZdm2Wh2Cl6KVQalKg_m4NhTPZqq-8SzEVO6s/edit?gid=0#gid=0 (6th of November)

Criticality semantics across Cloud platforms, vendors and Kubernetes https://docs.google.com/document/d/1-CpYLvDno6xb0eOw8bRvGwoac4kVtNXMZEF5ZXX0crs/edit?tab=t.0#heading=h.h6taytmbl3ub

Changes

This PR introduces a new semantic convention attribute service.criticality to enable classification of services based on their operational importance. This attribute will allow observability platforms to implement criticality-aware tracing, and sampling strategies.

Important

Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

@bachgarash bachgarash requested review from a team as code owners November 14, 2025 18:01
@github-actions github-actions Bot added enhancement New feature or request area:service labels Nov 14, 2025
@bachgarash
Copy link
Copy Markdown
Contributor Author

bachgarash commented Nov 14, 2025 •
edited
Loading

Links to the prototypes or existing instrumentations (when adding or changing conventions)

I need help with guidance on how to provide prototype for a newly introduced semantic convention attribute. Please, feel free drop your idea. Thanks in advance!

@lmolkova lmolkova moved this from Untriaged to Awaiting codeowners approval in Semantic Conventions Triage Nov 17, 2025
@bachgarash bachgarash requested a review from a team as a code owner November 17, 2025 20:28
jsuereth
jsuereth approved these changes Nov 20, 2025
View reviewed changes
Comment thread model/service/entities.yaml Outdated
@jsuereth
Copy link
Copy Markdown
Contributor

jsuereth commented Nov 20, 2025

Note: The build is failing - My approval is for the proposed change, but please clean up the build and get all tests to pass. I believe this needs a make table-generation registry-generation pass at a minimum, and possibly other cleanups .

@bachgarash bachgarash requested a review from jsuereth November 20, 2025 16:10
@bachgarash bachgarash requested a review from a team as a code owner November 27, 2025 18:03
@thompson-tomo
Copy link
Copy Markdown
Contributor

thompson-tomo commented Nov 28, 2025

@bachgarash can you regenerate the docs to take on the changes to the documentation templates?

@bachgarash
Copy link
Copy Markdown
Contributor Author

bachgarash commented Nov 28, 2025

Hi there. I have added a basic prototype into Otel-demo as requested

open-telemetry/opentelemetry-demo#2770

@bachgarash bachgarash force-pushed the feat/service-criticality-attribute branch from 9679b6a to 0de4ab4 Compare November 28, 2025 09:11
@bachgarash bachgarash requested review from a team as code owners November 28, 2025 09:11
@bachgarash bachgarash requested a review from a team November 28, 2025 09:11
@bachgarash bachgarash requested review from a team as code owners November 28, 2025 09:11
@github-actions github-actions Bot removed the Stale label Jan 6, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 20, 2026

This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 7 days.

@github-actions github-actions Bot added the Stale label Jan 20, 2026
@bachgarash
feat: introduce new service.criticality attribute
995d283 
Fixes open-telemetry#2986

This PR introduces a new semantic convention attribute service.criticality
to enable classification of services based on their operational importance.
This attribute allows observability platforms to implement criticality-aware
tracing and sampling strategies.

Changes:
- Add service.criticality attribute to the service entity (not service.instance)
- Add enum values: critical, high, medium, low
- Update registry and documentation
@bachgarash
feat: update documentation
de005f6
@bachgarash bachgarash force-pushed the feat/service-criticality-attribute branch from 08b5c96 to de005f6 Compare January 20, 2026 08:56
@lmolkova lmolkova moved this from Blocked to Awaiting codeowners approval in Semantic Conventions Triage Jan 20, 2026
@lmolkova lmolkova removed the Stale label Jan 20, 2026
@lmolkova
Copy link
Copy Markdown
Member

lmolkova commented Jan 20, 2026

@open-telemetry/semconv-service-and-deployment-approvers could you please take another look?

@lmolkova lmolkova enabled auto-merge January 23, 2026 02:09
@lmolkova lmolkova added this pull request to the merge queue Jan 23, 2026
Merged via the queue into open-telemetry:main with commit e9da642 Jan 23, 2026
23 of 25 checks passed
Copilot AI pushed a commit that referenced this pull request Jan 26, 2026
@bachgarash
feat: introduce new service.criticality attribute (#2986) (#3088)
37af268
This was referenced Jan 29, 2026
Closed
Merged
@nlamirault nlamirault mentioned this pull request Mar 12, 2026
Closed
4 tasks
@bachgarash bachgarash mentioned this pull request Mar 21, 2026
Merged
4 tasks
Ayushi-12 pushed a commit to Ayushi-12/semantic-conventions that referenced this pull request Apr 22, 2026
Introduce data attribute group for governance and security (open-tele…
3c72528 
…metry#3088)
Ayushi-12 added a commit to Ayushi-12/semantic-conventions that referenced this pull request Apr 22, 2026
@Ayushi-12
Introduce data attribute group for governance and security (open-tele…
4407831 
…metry#3088)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsuereth jsuereth jsuereth approved these changes

@lmolkova lmolkova lmolkova approved these changes

@kamphaus kamphaus kamphaus approved these changes

@adrielp adrielp adrielp approved these changes

@mmanciop mmanciop Awaiting requested review from mmanciop

@joaopgrassi joaopgrassi Awaiting requested review from joaopgrassi

Assignees

No one assigned

Labels

area:service enhancement New feature or request

Projects

Semantic Conventions Triage
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New semconv attribute proposal - service.criticality

10 participants

@bachgarash @jsuereth @thompson-tomo @joaopgrassi @Ayushi-12 @trask @lmolkova @kamphaus @mmanciop @adrielp