Remove network.type from RPC spans and metrics#2857
Merged
Conversation
Co-authored-by: trask <[email protected]>
Copilot
AI
changed the title
[WIP] Remove
Remove Oct 2, 2025
network.type from RPC spans / metricsnetwork.type from RPC spans and metrics
trask
reviewed
Oct 2, 2025
Co-authored-by: trask <[email protected]>
trask
reviewed
Oct 3, 2025
trask
approved these changes
Oct 3, 2025
thompson-tomo
approved these changes
Oct 4, 2025
Contributor
|
@trask this will need a rebase now that grpc doc has been merged |
lmolkova
approved these changes
Oct 15, 2025
lmolkova
moved this from Untriaged
to Needs More Approval
in Semantic Conventions Triage
…9-d78d-4786-98a9-6d2482d055cc
jsuereth
approved these changes
Oct 28, 2025
lmolkova
moved this from Needs More Approval
to Ready to be Merged
in Semantic Conventions Triage
…9-d78d-4786-98a9-6d2482d055cc
github-project-automation
Bot
moved this from In Progress
to Done
in RPC Semantic Conventions Stability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
network.typefrom RPC attribute groups inmodel/rpc/common.yamlrpcattribute group (line 49)rpc.serverattribute group (line 88)rpc_service.serverattribute group (line 102)Summary
Successfully removed
network.typeattribute from all RPC spans and metrics following the same pattern used in PR #410 for HTTP. The attribute is still available in the registry for opt-in usage but is no longer included in RPC semantic conventions as a recommended attribute.Changes made:
network.typefrommodel/rpc/common.yamldocs/rpc/rpc-spans.md,docs/rpc/connect-rpc.md,docs/rpc/json-rpc.md.chloggen/2851.yamlAll validation checks pass:
✅ table-check
✅ schema-check
✅ misspell
✅ markdownlint
✅ chlog-validate
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.