Add in error type to rpc spans #2812#2852
Merged
joaopgrassi merged 5 commits intoopen-telemetry:mainfrom Oct 17, 2025
Merged
Conversation
Contributor
Author
|
Waiting on #2738 to progress this PR |
|
For JSON-RPC, Microsoft defines an Taking such a type name from the error object and using it as |
Contributor
Author
|
So for jsonrpc spans |
trask
approved these changes
Oct 9, 2025
Co-authored-by: Trask Stalnaker <[email protected]>
053b989 to
cceb085
Compare
lmolkova
reviewed
Oct 15, 2025
lmolkova
approved these changes
Oct 16, 2025
auto-merge was automatically disabled
October 17, 2025 04:41
Head branch was pushed to by a user without write access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2812
Changes
The rpc spans now contains the error.type attribute for capturing that detail.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]