Skip to content

Ensure metrics are deprecated rather than removed#2829

Merged
trask merged 1 commit intoopen-telemetry:mainfrom
thompson-tomo:fix/#2828_DeprecateRatherThanRemove
Sep 30, 2025
Merged

Ensure metrics are deprecated rather than removed#2829
trask merged 1 commit intoopen-telemetry:mainfrom
thompson-tomo:fix/#2828_DeprecateRatherThanRemove

Conversation

@thompson-tomo
Copy link
Copy Markdown
Contributor

@thompson-tomo thompson-tomo commented Sep 30, 2025

Fixes #2828

Changes

With #2629 metrics were mistakenly removed rather than deprecated. This adds the metrics back in but as depreacted with the deprecation pointing to the new metrics.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

@thompson-tomo thompson-tomo force-pushed the fix/#2828_DeprecateRatherThanRemove branch from 5abdf15 to 88122f4 Compare September 30, 2025 02:21
Copy link
Copy Markdown
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think that looks right [he says naively].

@github-project-automation github-project-automation Bot moved this from Untriaged to Needs More Approval in Semantic Conventions Triage Sep 30, 2025
@trask trask added this pull request to the merge queue Sep 30, 2025
Merged via the queue into open-telemetry:main with commit 5bb24bb Sep 30, 2025
16 of 19 checks passed
@thompson-tomo thompson-tomo deleted the fix/#2828_DeprecateRatherThanRemove branch September 30, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

v1.37.0 removed system.network.dropped and system.network.packets instead of deprecating them

5 participants