Adds network protocol attribute to rpc signals #2719#2767
Merged
trask merged 4 commits intoopen-telemetry:mainfrom Oct 16, 2025
Merged
Adds network protocol attribute to rpc signals #2719#2767trask merged 4 commits intoopen-telemetry:mainfrom
trask merged 4 commits intoopen-telemetry:mainfrom
Conversation
Contributor
Author
|
Will need to remain as draft until question in issue is answered and also a prior pr merged to avoid conflicts |
|
When a parent process and a child process communicate using JSON-RPC over anonymous pipes, I think |
0b577c6 to
80f271a
Compare
Contributor
Author
trask
approved these changes
Oct 9, 2025
Co-authored-by: Trask Stalnaker <[email protected]>
ee009c0 to
3e7a1f4
Compare
lmolkova
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2719
Changes
This adds in the network.protocol.name and network.protocol.version attribute to both metrics and spans.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]