Skip to content

Adds network protocol attribute to rpc signals #2719#2767

Merged
trask merged 4 commits intoopen-telemetry:mainfrom
thompson-tomo:feature/#2719_AddNetworkProtocol
Oct 16, 2025
Merged

Adds network protocol attribute to rpc signals #2719#2767
trask merged 4 commits intoopen-telemetry:mainfrom
thompson-tomo:feature/#2719_AddNetworkProtocol

Conversation

@thompson-tomo
Copy link
Copy Markdown
Contributor

@thompson-tomo thompson-tomo commented Sep 11, 2025

Fixes #2719

Changes

This adds in the network.protocol.name and network.protocol.version attribute to both metrics and spans.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

@thompson-tomo
Copy link
Copy Markdown
Contributor Author

Will need to remain as draft until question in issue is answered and also a prior pr merged to avoid conflicts

@KalleOlaviNiemitalo
Copy link
Copy Markdown

When a parent process and a child process communicate using JSON-RPC over anonymous pipes, I think network.transport should be pipe, while network.protocol.name, network.protocol.version, and network.type should be omitted. This pull request lists them as Recommend rather than Required, so it's OK in that respect.

@thompson-tomo thompson-tomo changed the title Adds network protocol attribute to signals #2719 Adds network protocol attribute to rpc signals #2719 Sep 11, 2025
@thompson-tomo thompson-tomo marked this pull request as ready for review September 18, 2025 03:26
@thompson-tomo thompson-tomo marked this pull request as draft September 23, 2025 11:37
@thompson-tomo thompson-tomo force-pushed the feature/#2719_AddNetworkProtocol branch 4 times, most recently from 0b577c6 to 80f271a Compare October 2, 2025 01:20
@thompson-tomo
Copy link
Copy Markdown
Contributor Author

Waiting on #2738 to progress this PR & network.type will be removed with #2851

Comment thread .chloggen/rpc_gains_network_protocol.yaml Outdated
Comment thread .chloggen/rpc_gains_network_protocol.yaml Outdated
@thompson-tomo thompson-tomo force-pushed the feature/#2719_AddNetworkProtocol branch from ee009c0 to 3e7a1f4 Compare October 9, 2025 01:28
@thompson-tomo thompson-tomo marked this pull request as ready for review October 9, 2025 01:28
Comment thread model/rpc/common.yaml
Comment thread model/rpc/common.yaml
@github-project-automation github-project-automation Bot moved this from Untriaged to Needs More Approval in Semantic Conventions Triage Oct 15, 2025
@trask trask added this pull request to the merge queue Oct 16, 2025
Merged via the queue into open-telemetry:main with commit a7d4b41 Oct 16, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:rpc enhancement New feature or request

Development

Successfully merging this pull request may close these issues.

RPC: add network.protocol.name|version to spans and metrics

4 participants