Adds in grpc span definitions #2720#2738
Merged
trask merged 4 commits intoopen-telemetry:mainfrom Oct 9, 2025
Merged
Conversation
thompson-tomo
force-pushed
the
feature/#2720_Add_gRPC_spans
branch
2 times, most recently
from
cf3dafa to
60da02e
Compare
thompson-tomo
force-pushed
the
feature/#2720_Add_gRPC_spans
branch
from
60da02e to
535d3f8
Compare
Contributor
Author
|
Waiting for #2503 to be merged and then this can be rebased to be ready for review. |
thompson-tomo
force-pushed
the
feature/#2720_Add_gRPC_spans
branch
2 times, most recently
from
28aee86 to
6011baf
Compare
lmolkova
reviewed
Oct 1, 2025
thompson-tomo
force-pushed
the
feature/#2720_Add_gRPC_spans
branch
from
43f65c5 to
2d9d15a
Compare
trask
approved these changes
Oct 2, 2025
This was referenced Oct 2, 2025
jsuereth
approved these changes
Oct 9, 2025
Contributor
jsuereth
left a comment
jsuereth
left a comment
There was a problem hiding this comment.
I'm fine moving this direction as this is just a clean-up.
however - we do need to pull the gRPC folks into this discussion if we have any gRPC specific things / changes. We still have the issue where there are semantic conventions for RPC and gRPC has its own set of standards for OTEL.
github-project-automation
Bot
moved this from Untriaged
to Needs More Approval
in Semantic Conventions Triage
Member
It's on our project board todo list: #1773 |
github-project-automation
Bot
moved this from In Progress
to Done
in RPC Semantic Conventions Stability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2720
Changes
This replaces the grpc attribute table with explicit span definitions.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]