Metric namespaces should not be pluralized#267
Conversation
fe2e8a0 to
8afc168
Compare
|
Just want to bring this comment from @dmitryax from #212 (comment)
I think we probably should do that before moving forward with this? If that has a large impact maybe we should reconsider things? CC @trask @jsuereth |
|
@joaopgrassi @mx-psi I don't think removing pluralization will be reconsidered (it actually already happened in the specification), but what we WOULD do is figure out how to provide soft/easy migraiton for users and avoid continual churn of this decision. |
|
@jsuereth sounds good! For the metrics we have today in the conventions I think we are fine, I'm just a bit worried with the ones from the collector, as described by @dmitryax here. I guess we will just have to come up with new names for it, and probably a general guideline for situations where removing the |
|
@joaopgrassi I think the example you list is clearly the case where it should be In other words, I think we should continue with merging this PR and work on clearing up semantics of existing metrics for clarity. |
Fixes #212
Changes
Metric namespaces SHOULD NOT be pluralized.
This affect these current metric namespaces:
system.processes.count->system.process.count(Renamesystem.processes.*namespace tosystem.process.*#266)system.processes.created->system.process.created(Renamesystem.processes.*namespace tosystem.process.*#266)db.client.connections.*->db.client.connection.*(Rename db.client.connections.* metric namespace to db.client.connection.* #259)jvm.threads.count->jvm.thread.count(done already)jvm.classes.count->jvm.class.count(done already)Merge requirement checklist
schema-next.yaml updated with changes to existing conventions.