Skip to content

Add Query http method #2642#2643

Merged
lmolkova merged 4 commits intoopen-telemetry:mainfrom
thompson-tomo:feature/#2642_AddHttpQueryMethod
Sep 2, 2025
Merged

Add Query http method #2642#2643
lmolkova merged 4 commits intoopen-telemetry:mainfrom
thompson-tomo:feature/#2642_AddHttpQueryMethod

Conversation

@thompson-tomo
Copy link
Copy Markdown
Contributor

@thompson-tomo thompson-tomo commented Aug 16, 2025

Fixes #2642

Changes

Adds in the http query method as recently introduced by the IETF. https://datatracker.ietf.org/doc/draft-ietf-httpbis-safe-method-w-body/?include_text=1

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

Comment thread .chloggen/add_http_query_method.yaml Outdated
Co-authored-by: Martin Costello <[email protected]>
@jsuereth jsuereth moved this from Untriaged to Awaiting codeowners approval in Semantic Conventions Triage Aug 18, 2025
Comment thread model/http/registry.yaml Outdated
Comment thread .chloggen/add_http_query_method.yaml Outdated
Co-authored-by: Liudmila Molkova <[email protected]>
@thompson-tomo thompson-tomo force-pushed the feature/#2642_AddHttpQueryMethod branch from 089090e to 3c8f7f5 Compare August 24, 2025 01:57
@lmolkova lmolkova moved this from Awaiting codeowners approval to Needs More Approval in Semantic Conventions Triage Aug 27, 2025
@trask
Copy link
Copy Markdown
Member

trask commented Aug 27, 2025

Fixes #2642

I'm not sure, since it doesn't change the default set of "known" methods:

HTTP request method value SHOULD be "known" to the instrumentation. By default, this convention defines "known" methods as the ones listed in RFC9110 and the PATCH method defined in RFC5789.

@thompson-tomo
Copy link
Copy Markdown
Contributor Author

I believe what @martincostello means by known methods is it is listed as a known value in the table. This does that and it would allow for the value to be used in the dotnet library which is what prompted #2642 to be raised with the dotnet discussion linked.

Comment thread model/http/registry.yaml
Comment thread model/http/registry.yaml
@lmolkova lmolkova moved this from Needs More Approval to Ready to be Merged in Semantic Conventions Triage Sep 2, 2025
@lmolkova lmolkova added this pull request to the merge queue Sep 2, 2025
Merged via the queue into open-telemetry:main with commit b321d3a Sep 2, 2025
15 checks passed
@thompson-tomo thompson-tomo deleted the feature/#2642_AddHttpQueryMethod branch September 3, 2025 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:http enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[Http] Add QUERY as a known value for http.request.method

6 participants