rename system.network.dropped to system.network.packet.dropped#2629
Merged
trask merged 3 commits intoopen-telemetry:mainfrom Aug 22, 2025
Merged
Conversation
mx-psi
previously approved these changes
Aug 14, 2025
Contributor
Author
|
Discussed this PR during System Semconv WG 14/08/2025, and we noticed that if we agree on this rename, we should also agree on renaming system.netowrk.errors. In addition, this rename does not align with the Moving to PR to draft for now. |
Contributor
Author
|
Update: the |
Contributor
Author
|
Moving back to review, renamed system.network.packets to system.network.packet.count so it complies with the pluralization guidelines. |
We discused this on the System semconv SIG meeting last week
mx-psi
approved these changes
Aug 21, 2025
lmolkova
approved these changes
Aug 22, 2025
ShipraJain01
pushed a commit
to ShipraJain01/semantic-conventions
that referenced
this pull request
Aug 29, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1700
Changes
Rename
system.network.droppedtosystem.network.packet.droppedandsystem.network.packetstosystem.network.packet.count.Merge requirement checklist
[chore]