Skip to content

rename system.network.dropped to system.network.packet.dropped#2629

Merged
trask merged 3 commits intoopen-telemetry:mainfrom
rogercoll:rename_system_network_dropped_metric
Aug 22, 2025
Merged

rename system.network.dropped to system.network.packet.dropped#2629
trask merged 3 commits intoopen-telemetry:mainfrom
rogercoll:rename_system_network_dropped_metric

Conversation

@rogercoll
Copy link
Copy Markdown
Contributor

@rogercoll rogercoll commented Aug 14, 2025

Fixes #1700

Changes

Rename system.network.dropped to system.network.packet.dropped and system.network.packets to system.network.packet.count.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

@rogercoll rogercoll marked this pull request as ready for review August 14, 2025 14:02
@rogercoll rogercoll requested review from a team as code owners August 14, 2025 14:02
mx-psi
mx-psi previously approved these changes Aug 14, 2025
@rogercoll rogercoll marked this pull request as draft August 14, 2025 14:54
@rogercoll
Copy link
Copy Markdown
Contributor Author

rogercoll commented Aug 14, 2025

Discussed this PR during System Semconv WG 14/08/2025, and we noticed that if we agree on this rename, we should also agree on renaming system.netowrk.errors. In addition, this rename does not align with the system.netowrk.packets metric and the pluralization guidelines.

Moving to PR to draft for now.

@rogercoll
Copy link
Copy Markdown
Contributor Author

Update: the system.network.errors does not need to be included in the packet namespace, it can include any errors received/transmitted by the network interface:

rx_errors
    Total number of bad packets received on this network device. This counter must include events counted by rx_length_errors, rx_crc_errors, rx_frame_errors and other errors not otherwise counted.
tx_errors
    Total number of transmit problems. This counter must include events counter by tx_aborted_errors, tx_carrier_errors, tx_fifo_errors, tx_heartbeat_errors, tx_window_errors and other errors not otherwise counted.

Source: https://www.kernel.org/doc/html/v6.7/networking/statistics.html

@rogercoll
Copy link
Copy Markdown
Contributor Author

Moving back to review, renamed system.network.packets to system.network.packet.count so it complies with the pluralization guidelines.

@rogercoll rogercoll marked this pull request as ready for review August 18, 2025 15:27
@mx-psi mx-psi dismissed their stale review August 18, 2025 15:29

We discused this on the System semconv SIG meeting last week

Copy link
Copy Markdown
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmolkova lmolkova moved this from Untriaged to Ready to be Merged in Semantic Conventions Triage Aug 22, 2025
@trask trask added this pull request to the merge queue Aug 22, 2025
Merged via the queue into open-telemetry:main with commit 68a52f6 Aug 22, 2025
17 checks passed
ShipraJain01 pushed a commit to ShipraJain01/semantic-conventions that referenced this pull request Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Consider renaming system.network.dropped to system.network.packet.dropped

5 participants