Skip to content

Conversation

@JamesNK
Copy link
Contributor

@JamesNK JamesNK commented Jul 11, 2025

Fixes #2509

Changes

Adds documentation for metrics added to ASP.NET Core identity.

Merge requirement checklist

@JamesNK JamesNK requested review from a team as code owners July 11, 2025 08:22
@JamesNK JamesNK requested a review from a team as a code owner July 11, 2025 08:24
@github-actions github-actions bot added the enhancement New feature or request label Jul 11, 2025
@JamesNK JamesNK force-pushed the jamesnk/identity-metrics branch from d67ce6b to 9b7971e Compare July 11, 2025 08:56
@JamesNK
Copy link
Contributor Author

JamesNK commented Jul 12, 2025

What's the right way to have _OTHER values? They're creating an error.

@thompson-tomo
Copy link
Contributor

thompson-tomo commented Jul 13, 2025

@JamesNK Have u tried removing the underscore from the Id? Note fields which are enums are not restricted to those known values but in fact other values can be sent hence reducing the need for _other.

Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I left a bunch of minor naming suggestions. The key question is what should be counted as errors. I assume IdentityError is an error and the code should appear on error.type. I'd argue that at least some of other results should be populated as errors (e.g. aspnetcore.identity.user.password_result = failure)

@JamesNK
Copy link
Contributor Author

JamesNK commented Jul 15, 2025

I need to investigate more for feedback on changing/removing some results and using error.type more.

@JamesNK JamesNK force-pushed the jamesnk/identity-metrics branch from 414a1d6 to 5b2b495 Compare July 15, 2025 05:37
@JamesNK
Copy link
Contributor Author

JamesNK commented Jul 15, 2025

Updated. I used most feedback. I notably I think aspnetcore.identity.result is still required.

@JamesNK
Copy link
Contributor Author

JamesNK commented Jul 16, 2025

Note: Don't merge this until .NET 10 preview 7 ships.

@JamesNK
Copy link
Contributor Author

JamesNK commented Jul 16, 2025

I fixed the generated markdown files by copying output from build. Is it possible to run the tooling on Windows to generate markdown? Or is WSL recommended?

Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some nits.

It'd be great to document (here in the comments) the reason why we report counters and not duration histograms.

@lmolkova
Copy link
Member

lmolkova commented Jul 17, 2025

@JamesNK

I fixed the generated markdown files by copying output from build. Is it possible to run the tooling on Windows to generate markdown? Or is WSL recommended?

wsl is recommended. It's possible to install weaver https://github.com/open-telemetry/weaver/releases (or use docker image - otel/weaver) and run something like these two commands

weaver registry update-markdown --registry .\model --param registry_base_url=/docs/registry/ --target markdown --templates .\templates --future .\docs

and

weaver registry generate --registry .\model --templates .\templates markdown .\docs\registry\

which would be the same as make table-generation attribute-registry-generation

@lmolkova lmolkova moved this from Untriaged to Needs More Approval in Semantic Conventions Triage Jul 17, 2025
@lmolkova lmolkova moved this from Needs More Approval to Awaiting SIG approval in Semantic Conventions Triage Jul 17, 2025
@lmolkova
Copy link
Member

@open-telemetry/semconv-dotnet-approver @open-telemetry/dotnet-contrib-approvers @open-telemetry/dotnet-approvers PTAL

@JamesNK JamesNK force-pushed the jamesnk/identity-metrics branch from 31c579a to 997febb Compare August 4, 2025 05:42
@JamesNK
Copy link
Contributor Author

JamesNK commented Aug 13, 2025

All changes have been applied. Please take another look.

@lmolkova
Copy link
Member

LGTM!

could we please get an approval from @open-telemetry/semconv-dotnet-approver ?

@github-project-automation github-project-automation bot moved this from Awaiting codeowners approval to Needs More Approval in Semantic Conventions Triage Aug 17, 2025
@lmolkova lmolkova moved this from Needs More Approval to Ready to be Merged in Semantic Conventions Triage Aug 18, 2025
@github-project-automation github-project-automation bot moved this from Ready to be Merged to Needs More Approval in Semantic Conventions Triage Aug 18, 2025
@trask trask added this pull request to the merge queue Aug 19, 2025
Merged via the queue into open-telemetry:main with commit 62b23fa Aug 19, 2025
15 checks passed
ShipraJain01 pushed a commit to ShipraJain01/semantic-conventions that referenced this pull request Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:aspnetcore enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add ASP.NET Core Identity metrics

7 participants