-
Notifications
You must be signed in to change notification settings - Fork 301
Add ASP.NET Core identity metrics #2508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d67ce6b to
9b7971e
Compare
|
What's the right way to have |
|
@JamesNK Have u tried removing the underscore from the Id? Note fields which are enums are not restricted to those known values but in fact other values can be sent hence reducing the need for _other. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I left a bunch of minor naming suggestions. The key question is what should be counted as errors. I assume IdentityError is an error and the code should appear on error.type. I'd argue that at least some of other results should be populated as errors (e.g. aspnetcore.identity.user.password_result = failure)
|
I need to investigate more for feedback on changing/removing some results and using |
414a1d6 to
5b2b495
Compare
|
Updated. I used most feedback. I notably I think |
58df0d9 to
8d251c5
Compare
|
Note: Don't merge this until .NET 10 preview 7 ships. |
|
I fixed the generated markdown files by copying output from build. Is it possible to run the tooling on Windows to generate markdown? Or is WSL recommended? |
lmolkova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some nits.
It'd be great to document (here in the comments) the reason why we report counters and not duration histograms.
wsl is recommended. It's possible to install weaver https://github.com/open-telemetry/weaver/releases (or use docker image - weaver registry update-markdown --registry .\model --param registry_base_url=/docs/registry/ --target markdown --templates .\templates --future .\docsand weaver registry generate --registry .\model --templates .\templates markdown .\docs\registry\which would be the same as |
|
@open-telemetry/semconv-dotnet-approver @open-telemetry/dotnet-contrib-approvers @open-telemetry/dotnet-approvers PTAL |
31c579a to
997febb
Compare
|
All changes have been applied. Please take another look. |
|
LGTM! could we please get an approval from @open-telemetry/semconv-dotnet-approver ? |
Fixes #2509
Changes
Adds documentation for metrics added to ASP.NET Core identity.
Merge requirement checklist
[chore]