Skip to content

Add SQL commenter as context propagation for databases#2495

Merged
trask merged 4 commits intoopen-telemetry:mainfrom
XSAM:db-context-propagation-via-sql-commenter
Aug 25, 2025
Merged

Add SQL commenter as context propagation for databases#2495
trask merged 4 commits intoopen-telemetry:mainfrom
XSAM:db-context-propagation-via-sql-commenter

Conversation

@XSAM
Copy link
Copy Markdown
Member

@XSAM XSAM commented Jul 7, 2025 •
edited
Loading

Part of #2162, Replace #2236. All previous commits are copied to this PR.

This PR focused solely on the SQL commenter, as #2363 has been merged.

XSAM/otelsql#512 is the prototype that demonstrates the SQL commenter with the text attributes propagator.

Changes

Add SQL commenter as context propagation for databases

@XSAM XSAM requested review from a team as code owners July 7, 2025 22:41
@github-actions github-actions Bot added enhancement New feature or request area:db labels Jul 7, 2025
@XSAM
Copy link
Copy Markdown
Member Author

XSAM commented Jul 7, 2025

cc @lmolkova @pellared @Kielek @zacharycmontoya @nenadnoveljic @trask

@XSAM XSAM mentioned this pull request Jul 7, 2025
Closed
3 tasks
@frzifus
Copy link
Copy Markdown
Member

frzifus commented Jul 8, 2025

cc @simonpasquier

pellared
pellared approved these changes Jul 8, 2025
View reviewed changes
Comment thread docs/database/database-spans.md Outdated
zacharycmontoya
zacharycmontoya reviewed Jul 8, 2025
View reviewed changes
Comment thread docs/database/database-spans.md Outdated
@Kielek Kielek mentioned this pull request Jul 9, 2025
Merged
4 tasks
Kielek
Kielek reviewed Jul 9, 2025
View reviewed changes
Comment thread docs/database/database-spans.md Outdated
cheempz
cheempz reviewed Jul 9, 2025
View reviewed changes
Comment thread docs/database/database-spans.md Outdated
lmolkova
lmolkova reviewed Jul 11, 2025
View reviewed changes
Comment thread docs/database/database-spans.md Outdated
Comment thread docs/database/database-spans.md Outdated
Comment thread docs/database/database-spans.md Outdated
Comment thread docs/database/database-spans.md Outdated
@jerrytfleung jerrytfleung mentioned this pull request Jul 14, 2025
Closed
@XSAM XSAM requested a review from lmolkova July 16, 2025 00:47
brettmc
brettmc reviewed Jul 16, 2025
View reviewed changes
Comment thread docs/database/database-spans.md Outdated
@jsuereth jsuereth moved this from Untriaged to Awaiting codeowners approval in Semantic Conventions Triage Jul 28, 2025
trask
trask reviewed Jul 28, 2025
View reviewed changes
Comment thread docs/database/database-spans.md Outdated
Comment thread docs/database/database-spans.md
trask
trask reviewed Jul 28, 2025
View reviewed changes
Comment thread docs/database/database-spans.md Outdated
cristiangreco
cristiangreco reviewed Jul 29, 2025
View reviewed changes
Comment thread docs/database/database-spans.md Outdated
nenadnoveljic
nenadnoveljic reviewed Jul 30, 2025
View reviewed changes
Comment thread docs/database/database-spans.md Outdated
@XSAM XSAM requested a review from trask July 31, 2025 06:35
@XSAM
Copy link
Copy Markdown
Member Author

XSAM commented Aug 4, 2025

@open-telemetry/semconv-db-approvers PTAL

trask
trask reviewed Aug 4, 2025
View reviewed changes
Comment thread docs/database/database-spans.md Outdated
@XSAM
Copy link
Copy Markdown
Member Author

XSAM commented Aug 7, 2025

@trask, I find all comments are resolved. Is that okay for you to approve this PR?

@XSAM XSAM requested review from a team as code owners August 25, 2025 07:00
@XSAM XSAM requested a review from a team August 25, 2025 07:00
@XSAM XSAM requested review from a team and tigrannajaryan as code owners August 25, 2025 07:00
@XSAM XSAM force-pushed the db-context-propagation-via-sql-commenter branch from 247551d to b0372cb Compare August 25, 2025 07:08
@XSAM
Copy link
Copy Markdown
Member Author

XSAM commented Aug 25, 2025

Sorry for accidentally triggering so many reviewing groups... 🥲

@XSAM
Copy link
Copy Markdown
Member Author

XSAM commented Aug 25, 2025

@open-telemetry/specs-semconv-maintainers, all comments are resolved. Could we merge this PR?

@trask trask moved this from Needs More Approval to Ready to be Merged in Semantic Conventions Triage Aug 25, 2025
@trask trask added this pull request to the merge queue Aug 25, 2025
Merged via the queue into open-telemetry:main with commit 224f107 Aug 25, 2025
15 checks passed
@lmolkova lmolkova mentioned this pull request Aug 25, 2025
Closed
@XSAM XSAM deleted the db-context-propagation-via-sql-commenter branch August 27, 2025 16:01
@XSAM XSAM mentioned this pull request Sep 8, 2025
Closed
@jerrytfleung jerrytfleung mentioned this pull request Sep 17, 2025
Merged
@XSAM XSAM mentioned this pull request Sep 19, 2025
Merged
@laurit laurit mentioned this pull request Oct 8, 2025
Merged
@joaopgrassi joaopgrassi mentioned this pull request Oct 31, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trask trask trask left review comments

@lmolkova lmolkova lmolkova approved these changes

@pellared pellared pellared approved these changes

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan

+6 more reviewers

@cheempz cheempz cheempz left review comments

@cristiangreco cristiangreco cristiangreco left review comments

@brettmc brettmc brettmc left review comments

@Kielek Kielek Kielek left review comments

@nenadnoveljic nenadnoveljic nenadnoveljic approved these changes

@zacharycmontoya zacharycmontoya zacharycmontoya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:db enhancement New feature or request

Projects

Semantic Conventions Triage
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.