Skip to content

Add k8s.pod.phase and k8s.pod.status.reason metrics#2488

Merged
trask merged 3 commits intoopen-telemetry:mainfrom
ChrsMark:add_k8s_pod_phase
Sep 23, 2025
Merged

Add k8s.pod.phase and k8s.pod.status.reason metrics#2488
trask merged 3 commits intoopen-telemetry:mainfrom
ChrsMark:add_k8s_pod_phase

Conversation

@ChrsMark
Copy link
Copy Markdown
Member

@ChrsMark ChrsMark commented Jul 7, 2025

Fixes #2075

Changes

This PR adds the k8s.pod.phase and k8s.pod.status.reason metrics.

Merge requirement checklist

@ChrsMark ChrsMark requested review from a team as code owners July 7, 2025 08:59
@github-actions github-actions Bot added enhancement New feature or request area:k8s labels Jul 7, 2025
@ChrsMark ChrsMark moved this to In Review in K8s SemConv SIG Jul 7, 2025
@ChrsMark ChrsMark moved this from Untriaged to Awaiting SIG approval in Semantic Conventions Triage Jul 7, 2025
@ChrsMark ChrsMark force-pushed the add_k8s_pod_phase branch 3 times, most recently from f2db85f to d852615 Compare July 7, 2025 09:35
@ChrsMark ChrsMark requested a review from a team as a code owner July 7, 2025 09:35
Comment thread model/k8s/registry.yaml Outdated
Comment thread model/k8s/registry.yaml Outdated
@ChrsMark ChrsMark force-pushed the add_k8s_pod_phase branch from 930c71e to 522c2c4 Compare July 8, 2025 07:18
Comment thread docs/system/k8s-metrics.md
Copy link
Copy Markdown
Contributor

@povilasv povilasv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Comment thread docs/system/k8s-metrics.md
@ChrsMark ChrsMark requested review from dashpole and povilasv July 11, 2025 07:13
Comment thread docs/non-normative/k8s-migration.md
Comment thread docs/system/k8s-metrics.md
Comment thread docs/system/k8s-metrics.md
Comment thread docs/non-normative/k8s-migration.md Outdated
Comment thread docs/non-normative/k8s-migration.md Outdated
Comment thread docs/system/k8s-metrics.md
Copy link
Copy Markdown
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but lets wait to merge until the discussion around names and attributes matching exactly is resolved.

@ChrsMark ChrsMark moved this from In Review to Blocked in K8s SemConv SIG Sep 1, 2025
@ChrsMark ChrsMark force-pushed the add_k8s_pod_phase branch 2 times, most recently from 7ed6059 to 93e0e26 Compare September 11, 2025 09:25
@ChrsMark
Copy link
Copy Markdown
Member Author

@open-telemetry/semconv-k8s-approvers please take a final look since this one is not blocked any more by #2472 (needs another approval from the group).

@ChrsMark ChrsMark moved this from Blocked to In Review in K8s SemConv SIG Sep 17, 2025
@ChrsMark ChrsMark moved this from In Review to Approved by K8s SIG in K8s SemConv SIG Sep 22, 2025
@ChrsMark ChrsMark moved this from Awaiting codeowners approval to Needs More Approval in Semantic Conventions Triage Sep 22, 2025
@ChrsMark
Copy link
Copy Markdown
Member Author

@open-telemetry/specs-semconv-approvers @open-telemetry/specs-semconv-maintainers this one is approved by the K8S SIG. Please take a look.

Comment thread model/k8s/registry.yaml Outdated
@lmolkova lmolkova enabled auto-merge September 23, 2025 15:35
@lmolkova lmolkova added this pull request to the merge queue Sep 23, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Sep 23, 2025
@trask trask added this pull request to the merge queue Sep 23, 2025
Merged via the queue into open-telemetry:main with commit 869ed36 Sep 23, 2025
16 checks passed
@github-project-automation github-project-automation Bot moved this from Approved by K8s SIG to Done in K8s SemConv SIG Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:k8s enhancement New feature or request

Projects

Status: Done
Archived in project

Development

Successfully merging this pull request may close these issues.

[k8s] Define semantic conventions for k8s pod resource (status, phase etc)

10 participants