[chore] Non-normative guidance for status metrics#2472
[chore] Non-normative guidance for status metrics#2472lmolkova merged 6 commits intoopen-telemetry:mainfrom
Conversation
This PR adds non-normative guidance for designing status metrics. This is a common metric pattern that has confused contributors in the past, so this document exists to clear up some misconceptions and outline a unified design plan.
joaopgrassi
left a comment
There was a problem hiding this comment.
Thank you for putting this together!
Well, in your original issue you described the need to observe/monitor the state/heartbeat of an app. This now described a state metric which basically can be used to report a boolean state 1/0/on/off using an UpDownCounter. |
|
@joaopgrassi Agreed. Took a look at it again this morning with fresh eyes and it makes sense to me. Thank you! |
|
Summer busy-ness and other fires to put out has forced me to push this off for longer than I meant to. I still intend to come back and clean this up based on review comments. |
ChrsMark
left a comment
There was a problem hiding this comment.
Thank's for putting this together!
There was a problem hiding this comment.
Pull Request Overview
This PR introduces non-normative guidance for designing status metrics in the OpenTelemetry semantic conventions. The document aims to clarify common misconceptions and provide a unified design approach for metrics that represent entities in specific states.
Key changes:
- Creates a new guidance document defining "status metrics" and their design patterns
- Establishes conventions for instrument type, naming, and attribute usage
- Provides clarification on when to use entity attributes vs. status metrics
|
When building "JMX state metrics" in Java instrumentation we took inspiration from the I am not aware of any other similar status metric elsewhere, but my knowledge is quite limited here so maybe an exhaustive review would be needed to identify other candidates for alignment. |
|
My bad, I should have paid more attention while reading it. The good news is that there is nothing to change then, maybe as a follow-up adding a link from |
Fixes #1554
Changes
This PR adds non-normative guidance for designing status metrics. This is a common metric pattern that has confused contributors in the past, so this document exists to clear up some misconceptions and outline a unified design plan.
Merge requirement checklist
[chore]