Skip to content

Add {k8s.node, k8s.pod, container}.filesystem. metrics#2392

Merged
joaopgrassi merged 4 commits intoopen-telemetry:mainfrom
ChrsMark:add_k8s_fs_metrics
Jul 14, 2025
Merged

Add {k8s.node, k8s.pod, container}.filesystem. metrics#2392
joaopgrassi merged 4 commits intoopen-telemetry:mainfrom
ChrsMark:add_k8s_fs_metrics

Conversation

@ChrsMark
Copy link
Copy Markdown
Member

@ChrsMark ChrsMark commented Jun 19, 2025 •
edited
Loading

Fixes #1488

Changes

This PR adds the following metrics that the Collector already implementes:

k8s.node.filesystem.available
k8s.node.filesystem.capacity
k8s.node.filesystem.usage
k8s.pod.filesystem.available
k8s.pod.filesystem.capacity
k8s.pod.filesystem.usage
container.filesystem.available
container.filesystem.capacity
container.filesystem.usage

Merge requirement checklist

@ChrsMark ChrsMark requested review from a team as code owners June 19, 2025 12:05
@github-actions github-actions Bot added enhancement New feature or request area:k8s labels Jun 19, 2025
@ChrsMark ChrsMark force-pushed the add_k8s_fs_metrics branch from 8d98e5e to f5567ed Compare June 19, 2025 12:06
@ChrsMark ChrsMark requested a review from a team June 19, 2025 12:06
@ChrsMark ChrsMark moved this to In Review in K8s SemConv SIG Jun 19, 2025
@ChrsMark ChrsMark moved this from Untriaged to Awaiting SIG approval in Semantic Conventions Triage Jun 19, 2025
@ChrsMark ChrsMark force-pushed the add_k8s_fs_metrics branch 2 times, most recently from 69a14ba to c20c0c3 Compare June 19, 2025 12:14
@ChrsMark ChrsMark changed the title Add k8s.{node, pod, container}.filesystem. metrics Add {k8s.node, k8s.pod, container}.filesystem. metrics Jun 19, 2025
@ChrsMark ChrsMark force-pushed the add_k8s_fs_metrics branch from c20c0c3 to 0ce4fcb Compare June 19, 2025 12:47
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 5, 2025

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions Bot added the Stale label Jul 5, 2025
@ChrsMark
Copy link
Copy Markdown
Member Author

ChrsMark commented Jul 5, 2025

Still active. @open-telemetry/semconv-k8s-approvers please take a look.

@github-actions github-actions Bot removed the Stale label Jul 6, 2025
@ChrsMark ChrsMark force-pushed the add_k8s_fs_metrics branch 4 times, most recently from e5d4a77 to 173b0ee Compare July 7, 2025 09:06
dashpole
dashpole reviewed Jul 7, 2025
View reviewed changes
Comment thread model/container/metrics.yaml Outdated
@ChrsMark ChrsMark force-pushed the add_k8s_fs_metrics branch from 173b0ee to c2663ba Compare July 8, 2025 07:14
@ChrsMark ChrsMark requested a review from dashpole July 8, 2025 07:18
@ChrsMark ChrsMark force-pushed the add_k8s_fs_metrics branch from c2663ba to f1199ce Compare July 8, 2025 07:25
@ChrsMark ChrsMark force-pushed the add_k8s_fs_metrics branch from f1199ce to 01908a4 Compare July 8, 2025 07:28
jinja2
jinja2 reviewed Jul 9, 2025
View reviewed changes
Comment thread docs/non-normative/k8s-migration.md Outdated
Comment thread docs/non-normative/k8s-migration.md Outdated
@ChrsMark ChrsMark moved this from In Review to Approved by K8s SIG in K8s SemConv SIG Jul 10, 2025
@ChrsMark ChrsMark moved this from Awaiting SIG approval to Needs More Approval in Semantic Conventions Triage Jul 10, 2025
joaopgrassi
joaopgrassi reviewed Jul 11, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@joaopgrassi joaopgrassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits

Comment thread model/k8s/metrics.yaml Outdated
Comment thread model/k8s/metrics.yaml
Comment thread model/container/metrics.yaml Outdated
@ChrsMark
improve brief
c8a1cc9 
Signed-off-by: ChrsMark <[email protected]>
@joaopgrassi joaopgrassi added this pull request to the merge queue Jul 14, 2025
Merged via the queue into open-telemetry:main with commit df18eea Jul 14, 2025
15 checks passed
@github-project-automation github-project-automation Bot moved this from Approved by K8s SIG to Done in K8s SemConv SIG Jul 14, 2025
@ChrsMark ChrsMark deleted the add_k8s_fs_metrics branch July 14, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jinja2 jinja2 jinja2 left review comments

@dashpole dashpole dashpole approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@dmitryax dmitryax dmitryax approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

+1 more reviewer

@povilasv povilasv povilasv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:k8s enhancement New feature or request

Projects

K8s SemConv SIG
Status: Done
Semantic Conventions Triage
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[k8s] Define semantic conventions for k8s filesystem metrics

7 participants

@ChrsMark @dashpole @joaopgrassi @dmitryax @TylerHelmuth @jinja2 @povilasv