Skip to content

Automate schema-next generation in release workflow#2307

Merged
lmolkova merged 2 commits intoopen-telemetry:mainfrom
lmolkova:automate-schema-next
Jul 11, 2025
Merged

Automate schema-next generation in release workflow#2307
lmolkova merged 2 commits intoopen-telemetry:mainfrom
lmolkova:automate-schema-next

Conversation

@lmolkova
Copy link
Copy Markdown
Member

Fixes #1426

This PR automates schema-next generation. Proposed process changes:

  • schema-next.yaml is deleted, PR authors should not update it
  • reviewers should review deprecated property - it has to be structured and should use proper reason. Only renamed on attributes and metrics is included into generated schema-next.
  • schemas/$version is generated only at the release time using weaver diff

Copy link
Copy Markdown
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to clarify some limitations, but this looks like a huge improvement for us.

Comment thread internal/tools/scripts/generate-schema-next.sh Outdated
Comment thread internal/tools/scripts/schema-diff/yaml/schema-diff.j2
Comment thread internal/tools/scripts/schema-diff/yaml/schema-diff.j2 Outdated
@lmolkova lmolkova moved this from Needs More Approval to Blocked in Semantic Conventions Triage Jun 8, 2025
@lmolkova
Copy link
Copy Markdown
Member Author

lmolkova commented Jun 8, 2025

blocked on open-telemetry/weaver#776

@github-actions
Copy link
Copy Markdown

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions Bot added the Stale label Jun 24, 2025
@lmolkova lmolkova moved this from Blocked to Needs More Approval in Semantic Conventions Triage Jun 27, 2025
@lmolkova
Copy link
Copy Markdown
Member Author

lmolkova commented Jun 27, 2025

Now blocked on #2444 (weaver version update)

@lmolkova lmolkova moved this from Needs More Approval to Blocked in Semantic Conventions Triage Jun 27, 2025
@github-actions github-actions Bot removed the Stale label Jun 28, 2025
@trask trask modified the milestone: v1.35.0 Jun 30, 2025
@lmolkova lmolkova force-pushed the automate-schema-next branch from b64c2fc to 9275339 Compare July 2, 2025 21:41
@lmolkova lmolkova requested a review from a team as a code owner July 2, 2025 21:41
@lmolkova lmolkova mentioned this pull request Jul 3, 2025
@lmolkova lmolkova moved this from Blocked to Needs More Approval in Semantic Conventions Triage Jul 5, 2025
@lmolkova lmolkova force-pushed the automate-schema-next branch from 76cb5ab to f40b0aa Compare July 5, 2025 17:35
@lmolkova lmolkova force-pushed the automate-schema-next branch from dcd406e to 62d046a Compare July 5, 2025 17:39
@lmolkova lmolkova enabled auto-merge July 11, 2025 01:49
@lmolkova lmolkova added this pull request to the merge queue Jul 11, 2025
Merged via the queue into open-telemetry:main with commit 0c4e76a Jul 11, 2025
22 checks passed
@lmolkova lmolkova deleted the automate-schema-next branch July 11, 2025 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog Label to skip the changelog check

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Automate schema-next generation

4 participants