New convention: raid#2294
Closed
jherbage wants to merge 64 commits intoopen-telemetry:mainfrom
Closed
Conversation
lmolkova
moved this from Untriaged
to Awaiting SIG approval
in Semantic Conventions Triage
3 tasks
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
braydonk
reviewed
Jun 10, 2025
Contributor
thompson-tomo
left a comment
thompson-tomo
left a comment
There was a problem hiding this comment.
Would be great if we did not restrict it to Linux.
…s on events only (open-telemetry#2240) Co-authored-by: Trask Stalnaker <[email protected]> Co-authored-by: Robert Pająk <[email protected]>
…#2305) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
open-telemetry#2196) Signed-off-by: ChrsMark <[email protected]> Co-authored-by: Jina Jain <[email protected]> Co-authored-by: Liudmila Molkova <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
open-telemetry#1784) Co-authored-by: Christos Markou <[email protected]> Co-authored-by: Jina Jain <[email protected]> Co-authored-by: Liudmila Molkova <[email protected]>
braydonk
reviewed
Jul 9, 2025
thompson-tomo
suggested changes
Jul 10, 2025
github-project-automation
Bot
moved this from Awaiting SIG approval
to Blocked
in Semantic Conventions Triage
thompson-tomo
suggested changes
Jul 14, 2025
…o status in metric
lmolkova
moved this from Blocked
to Awaiting SIG approval
in Semantic Conventions Triage
thompson-tomo
approved these changes
Jul 17, 2025
braydonk
approved these changes
Jul 21, 2025
joaopgrassi
requested changes
Oct 15, 2025
Comment on lines
+3
to
+5
| path_base_for_github_subdir: | ||
| from: content/en/docs/specs/semconv/http/_index.md | ||
| to: http/README.md |
Member
There was a problem hiding this comment.
Suggested change
| path_base_for_github_subdir: | |
| from: content/en/docs/specs/semconv/http/_index.md | |
| to: http/README.md |
The doc is also missing the main header
| change_type: new_component | ||
|
|
||
| # The name of the area of concern in the attributes-registry, (e.g. http, cloud, db) | ||
| component: system |
Member
There was a problem hiding this comment.
Suggested change
| component: system | |
| component: storage |
| component: system | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Proposed metric semantics for a scraper in hostreceiver scraping raid metrics related to multiple device RAID disks |
Member
There was a problem hiding this comment.
Maybe make this note more generic, something like: Introduce storage attributes and metrics
github-project-automation
Bot
moved this from Awaiting codeowners approval
to Blocked
in Semantic Conventions Triage
Member
|
Please also update the PR title as it's not up-to-date with the changes. |
| attributes: | ||
| - ref: storage.volume.name | ||
| - ref: hw.state | ||
| - ref: hw.type |
Contributor
There was a problem hiding this comment.
I don't think that we need this.
| unit: "{disk}" | ||
| attributes: | ||
| - ref: storage.volume.name | ||
| - ref: hw.state |
Contributor
There was a problem hiding this comment.
Am thinking we should go with disk.mode to avoid overloading hw.state.
Member
|
@jherbage - thanks for the contribution! This PR adds new area - I'm going to close this PR because of the above reasons. Feel free to reopen if @open-telemetry/semconv-system-approvers would be ready to own the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes
Attributes describing the linux only multiple device RAID arrays and their states.
Metrics to be generated by a new scraper in hostreceiver to run only on linux systems to collect metrics about these raid devices based on an existing exporter available in Prometheus' node_exporter
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]I think this is n/a - all new stuff.