Skip to content

[k8s] Adds k8s.hpa.metric.target.cpu.* metrics#2283

Merged
trask merged 9 commits intoopen-telemetry:mainfrom
jinja2:k8s-hpa-cpu
Jun 30, 2025
Merged

[k8s] Adds k8s.hpa.metric.target.cpu.* metrics#2283
trask merged 9 commits intoopen-telemetry:mainfrom
jinja2:k8s-hpa-cpu

Conversation

@jinja2
Copy link
Copy Markdown
Contributor

@jinja2 jinja2 commented May 19, 2025

Fixes #2182

Changes

Adds metrics and attributes to track k8s HPA's metric target values for CPU resources.

Merge requirement checklist

Comment thread model/k8s/metrics.yaml
Comment thread model/k8s/metrics.yaml
Comment thread model/k8s/registry.yaml Outdated
@ChrsMark ChrsMark moved this to In Review in K8s SemConv SIG May 28, 2025
@lmolkova lmolkova moved this from Untriaged to Awaiting SIG approval in Semantic Conventions Triage May 29, 2025
Comment thread model/k8s/metrics.yaml Outdated
Comment thread model/k8s/metrics.yaml Outdated
Comment thread model/k8s/metrics.yaml Outdated
@jinja2 jinja2 requested a review from a team as a code owner June 5, 2025 18:08
Copy link
Copy Markdown
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Not sure if the open question of #2283 (comment) should block this or not. Probably we can proceed and revisit entity associations anyways.

@ChrsMark ChrsMark moved this from Awaiting SIG approval to Needs More Approval in Semantic Conventions Triage Jun 11, 2025
@ChrsMark ChrsMark moved this from In Review to Approved by K8s SIG in K8s SemConv SIG Jun 11, 2025
@jinja2
Copy link
Copy Markdown
Contributor Author

jinja2 commented Jun 16, 2025

@open-telemetry/specs-semconv-approvers this PR has SIG approvals. PTAL when you get a chance. Thanks!

@joaopgrassi joaopgrassi moved this from Needs More Approval to Ready to be Merged in Semantic Conventions Triage Jun 25, 2025
@ChrsMark
Copy link
Copy Markdown
Member

@jinja2 that will need a rebase :)

@jinja2
Copy link
Copy Markdown
Contributor Author

jinja2 commented Jun 26, 2025

Resolved conflicts

@trask
Copy link
Copy Markdown
Member

trask commented Jun 30, 2025

sorry, we didn't get to it in time, can you resolve the conflicts again? thanks

@trask trask enabled auto-merge June 30, 2025 15:05
@trask trask added this pull request to the merge queue Jun 30, 2025
Merged via the queue into open-telemetry:main with commit fe90e52 Jun 30, 2025
15 checks passed
@github-project-automation github-project-automation Bot moved this from Approved by K8s SIG to Done in K8s SemConv SIG Jun 30, 2025
jherbage pushed a commit to jherbage/semantic-conventions that referenced this pull request Jul 1, 2025
spurplewang pushed a commit to spurplewang/semantic-conventions that referenced this pull request Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:k8s enhancement New feature or request

Projects

Status: Done
Archived in project

Development

Successfully merging this pull request may close these issues.

[k8s.hpa] Add metrics/attrs for HPA metrics configuration

8 participants