K8s naming convention rational and additional documentation#2252
Merged
lmolkova merged 10 commits intoopen-telemetry:mainfrom Jun 1, 2025
Merged
K8s naming convention rational and additional documentation#2252lmolkova merged 10 commits intoopen-telemetry:mainfrom
lmolkova merged 10 commits intoopen-telemetry:mainfrom
Conversation
3 tasks
dmitryax
approved these changes
May 12, 2025
joaopgrassi
reviewed
May 13, 2025
lmolkova
reviewed
May 19, 2025
lmolkova
reviewed
May 19, 2025
lmolkova
reviewed
May 19, 2025
lmolkova
reviewed
May 19, 2025
lmolkova
reviewed
May 19, 2025
ChrsMark
approved these changes
May 21, 2025
trask
reviewed
May 21, 2025
dashpole
approved these changes
May 29, 2025
lmolkova
approved these changes
May 29, 2025
lmolkova
moved this from Untriaged
to Ready to be Merged
in Semantic Conventions Triage
ChrsMark
approved these changes
May 29, 2025
github-project-automation
Bot
moved this from Ready to be Merged
to Needs More Approval
in Semantic Conventions Triage
lmolkova
moved this from Needs More Approval
to Ready to be Merged
in Semantic Conventions Triage
trask
reviewed
May 29, 2025
trask
reviewed
May 29, 2025
Contributor
Author
|
@open-telemetry/semconv-k8s-approvers made some further edits, I would appreciate a 2nd look. Should we make some exceptions for fields if they map directly to a field in k8s spec? |
github-project-automation
Bot
moved this from Ready to be Merged
to Needs More Approval
in Semantic Conventions Triage
Member
|
@jinja2 @joaopgrassi could we resolve open discussion (it seems that some changes have been made)? |
chalin
reviewed
Jun 1, 2025
| The following guidelines are specific to Kubernetes: | ||
|
|
||
| - [Service in Kubernetes](../non-normative/k8s-attributes.md#service-attributes) | ||
| - [Additional naming guidance for Kubernetes](../non-normative/naming-known-exceptions.md#kubernetes-naming-exceptions) |
Contributor
There was a problem hiding this comment.
All: just a reminder that links should not point to page level 1 headings, because those don't exist in the published website. To see how this breaks the website build, visit https://github.com/open-telemetry/opentelemetry.io/actions/runs/15373995491/job/43256707459?pr=6948.
I'll submit a fix shortly.
Contributor
There was a problem hiding this comment.
jherbage
pushed a commit
to jherbage/semantic-conventions
that referenced
this pull request
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2245
Changes
Adds rationale and further guidance for naming Kubernetes resources.
Merge requirement checklist
[chore]