Add gen_ai.conversation.id attribute#2163
Merged
lmolkova merged 1 commit intoopen-telemetry:mainfrom May 7, 2025
Merged
Conversation
gyliu513
changed the title
Member
Author
|
@xrmx this is a follow up from your comments at https://github.com/open-telemetry/semantic-conventions/pull/1900/files#r2016253235 , but I was using |
lmolkova
moved this from Untriaged
to Awaiting SIG approval
in Semantic Conventions Triage
lmolkova
reviewed
Apr 27, 2025
xrmx
reviewed
Apr 28, 2025
gyliu513
changed the title
drewby
reviewed
May 1, 2025
Member
drewby
left a comment
drewby
left a comment
There was a problem hiding this comment.
I love this addition. I just had some minor feedback on the description and condition.
gyliu513
force-pushed
the
ssn
branch
2 times, most recently
from
0c5e767 to
af51528
Compare
lmolkova
reviewed
May 1, 2025
lmolkova
reviewed
May 1, 2025
lmolkova
reviewed
May 1, 2025
gyliu513
changed the title
gen_ai.conversation.id attribute
aabmass
reviewed
May 1, 2025
lmolkova
reviewed
May 4, 2025
xrmx
approved these changes
May 5, 2025
aabmass
approved these changes
May 5, 2025
lmolkova
approved these changes
May 5, 2025
github-project-automation
Bot
moved this from Awaiting SIG approval
to Needs More Approval
in Semantic Conventions Triage
lmolkova
reviewed
May 5, 2025
Member
|
@gyliu513 could you please resolve conflicts? It's ready to go otherwise |
lmolkova
pushed a commit
to lmolkova/semantic-conventions
that referenced
this pull request
May 13, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2024
Changes
Please provide a brief description of the changes here.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]