clarify code function name#1944
Merged
lmolkova merged 20 commits intoopen-telemetry:mainfrom Feb 28, 2025
Merged
Conversation
9 tasks
kamphaus
reviewed
Feb 27, 2025
Co-authored-by: Christophe Kamphaus <[email protected]>
Co-authored-by: Christophe Kamphaus <[email protected]>
kamphaus
approved these changes
Feb 27, 2025
trask
reviewed
Feb 27, 2025
lmolkova
reviewed
Feb 27, 2025
Co-authored-by: Liudmila Molkova <[email protected]>
… into clarify-code-function-name
trask
approved these changes
Feb 28, 2025
Co-authored-by: Trask Stalnaker <[email protected]>
Co-authored-by: Trask Stalnaker <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1677
Changes
code.function.nameto include fully qualified namecode.namespaceas the information is included incode.function.name.This is a breaking change for which any producer/consumer of
code.function.name,code.function(deprecated) orcode.namespaceis impacted. The changes are however expected to be performed once all attributes incode.*namespace have been made stable.Because the change is not a simple rename, we can't use the schema transformation, even if we had a way to perform complex transformations made possible by open-telemetry/opentelemetry-specification#4427, the transformation would have to be platform-specific and we might not have the ability to do that by relying only on the available data.
Merge requirement checklist
[chore]