Skip to content

clarify code function name#1944

Merged
lmolkova merged 20 commits intoopen-telemetry:mainfrom
SylvainJuge:clarify-code-function-name
Feb 28, 2025
Merged

clarify code function name#1944
lmolkova merged 20 commits intoopen-telemetry:mainfrom
SylvainJuge:clarify-code-function-name

Conversation

@SylvainJuge
Copy link
Copy Markdown
Contributor

@SylvainJuge SylvainJuge commented Feb 27, 2025

Fixes #1677

Changes

  • modify the definition of code.function.name to include fully qualified name
  • deprecate code.namespace as the information is included in code.function.name.

This is a breaking change for which any producer/consumer of code.function.name, code.function (deprecated) or code.namespace is impacted. The changes are however expected to be performed once all attributes in code.* namespace have been made stable.

Because the change is not a simple rename, we can't use the schema transformation, even if we had a way to perform complex transformations made possible by open-telemetry/opentelemetry-specification#4427, the transformation would have to be platform-specific and we might not have the ability to do that by relying only on the available data.

Merge requirement checklist

@SylvainJuge SylvainJuge marked this pull request as ready for review February 27, 2025 10:40
@SylvainJuge SylvainJuge requested review from a team as code owners February 27, 2025 10:40
Copy link
Copy Markdown
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread internal/tools/go.mod
Comment thread .chloggen/1646.yaml Outdated
Comment thread model/code/registry.yaml Outdated
Comment thread model/code/registry.yaml Outdated
Comment thread model/code/registry.yaml Outdated
Comment thread model/code/registry-deprecated.yaml Outdated
Comment thread docs/code/README.md Outdated
Comment thread model/code/registry.yaml
Comment thread model/code/registry.yaml
@github-project-automation github-project-automation Bot moved this from Untriaged to Needs More Approval in Semantic Conventions Triage Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Clarify values for code.function.name and code.namespace

6 participants