Skip to content

Add Semantic definitions for Oracle Database#1911

Merged
lmolkova merged 33 commits intoopen-telemetry:mainfrom
sudarshan12s:main
Apr 8, 2025
Merged

Add Semantic definitions for Oracle Database#1911
lmolkova merged 33 commits intoopen-telemetry:mainfrom
sudarshan12s:main

Conversation

@sudarshan12s
Copy link
Copy Markdown
Contributor

@sudarshan12s sudarshan12s commented Feb 17, 2025

Fixes #

Changes

Add semantic conventions for Oracle Database.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

sudarshan12s and others added 2 commits February 17, 2025 12:51
@sudarshan12s
semantic definitions for OracleDB (#1)
568df1a 
* - Add semantic conventions for oracle database
@sudarshan12s
- Remove semicolon in example
1616f49
@sudarshan12s sudarshan12s requested review from a team as code owners February 17, 2025 11:30
@sudarshan12s sudarshan12s mentioned this pull request Feb 18, 2025
Merged
jsuereth
jsuereth reviewed Mar 4, 2025
View reviewed changes
Comment thread schema-next.yaml Outdated
lmolkova
lmolkova requested changes Mar 6, 2025
View reviewed changes
Comment thread model/database/spans.yaml Outdated
Comment thread docs/attributes-registry/README.md Outdated
Comment thread model/oracledb/registry.yaml Outdated
Comment thread model/oracledb/registry.yaml Outdated
Comment thread model/oracledb/registry.yaml Outdated
@github-project-automation github-project-automation Bot moved this from Untriaged to Blocked in Semantic Conventions Triage Mar 6, 2025
@sudarshan12s
Update model/database/spans.yaml
fa073d8 
Co-authored-by: Liudmila Molkova <[email protected]>
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Mar 6, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@sudarshan12s sudarshan12s requested a review from a team as a code owner March 6, 2025 07:46
lmolkova
lmolkova reviewed Mar 10, 2025
View reviewed changes
Comment thread docs/database/oracledb.md Outdated
Comment thread docs/database/oracledb.md Outdated
Comment thread docs/database/oracledb.md Outdated
Comment thread docs/database/oracledb.md Outdated
@sudarshan12s sudarshan12s requested a review from lmolkova March 28, 2025 03:33
lmolkova
lmolkova reviewed Apr 2, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the only unresolved discussion is around oracle.db.client.connection.implicit_release - suggesting to remove it and tackle in a follow-up PR along with transport span definition.

Thanks a lot for pushing through!

@sudarshan12s sudarshan12s requested a review from lmolkova April 2, 2025 10:08
@sudarshan12s
Copy link
Copy Markdown
Contributor Author

sudarshan12s commented Apr 3, 2025

I believe the only unresolved discussion is around oracle.db.client.connection.implicit_release - suggesting to remove it and tackle in a follow-up PR along with transport span definition.

Thanks a lot for pushing through!

I have removed the attribute oracle.db.client.connection.implicit_release as suggested.

lmolkova
lmolkova reviewed Apr 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great with a tiny caveat on the doc status.

Comment thread docs/database/oracledb.md Outdated
@sudarshan12s
Update docs/database/oracledb.md
6fc5a9a 
Yes committed.

Co-authored-by: Liudmila Molkova <[email protected]>
@sudarshan12s sudarshan12s requested a review from lmolkova April 4, 2025 17:24
@lmolkova lmolkova moved this from Awaiting SIG approval to Needs More Approval in Semantic Conventions Triage Apr 4, 2025
@Kielek
Copy link
Copy Markdown
Member

Kielek commented Apr 7, 2025

@alexkeh, @pfdsilva, @muhaook, you were working on introducing instrumentation to the Oracle .NET Clients directly. Could you please review?

What is more, I think that you will need to update code in the clients.

Reference of the old issue where we discussed it open-telemetry/opentelemetry-dotnet-instrumentation#3192

@alexkeh
Copy link
Copy Markdown

alexkeh commented Apr 7, 2025

@Kielek I'm asking one of our Oracle team members to review this. Thanks for alerting us!

trask
trask approved these changes Apr 8, 2025
View reviewed changes
Comment thread .chloggen/add_oracledb_semconv.yaml Outdated
Comment thread model/database/spans.yaml
@trask trask mentioned this pull request Apr 8, 2025
Closed
@lmolkova lmolkova merged commit 0a52171 into open-telemetry:main Apr 8, 2025
14 of 15 checks passed
lmolkova pushed a commit to lmolkova/semantic-conventions that referenced this pull request May 13, 2025
@sudarshan12s
Add Semantic definitions for Oracle Database (open-telemetry#1911)
a8d6bc9 
Co-authored-by: Liudmila Molkova <[email protected]>
This was referenced Oct 29, 2025
Closed
Open
@sudarshan12s sudarshan12s mentioned this pull request Dec 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trask trask trask approved these changes

@lmolkova lmolkova lmolkova approved these changes

@jsuereth jsuereth Awaiting requested review from jsuereth

Assignees

No one assigned

Labels

None yet

Projects

Semantic Conventions Triage
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sudarshan12s @Kielek @alexkeh @jsuereth @trask @lmolkova