Skip to content

Fix units of process.open_file_descriptor.count and process.context_switches#1797

Merged
lmolkova merged 3 commits intoopen-telemetry:mainfrom
ChrsMark:fix_process_units
Feb 4, 2025
Merged

Fix units of process.open_file_descriptor.count and process.context_switches#1797
lmolkova merged 3 commits intoopen-telemetry:mainfrom
ChrsMark:fix_process_units

Conversation

@ChrsMark
Copy link
Copy Markdown
Member

@ChrsMark ChrsMark commented Jan 23, 2025

Fixes #1662

Changes

This PR fixes the units of process.open_file_descriptor.count and process.context_switches metrics.
I was not sure if it should be {open_file_descriptor} or just {file_descriptor} but went with what was proposed in #1662.

Merge requirement checklist

@ChrsMark ChrsMark requested review from a team as code owners January 23, 2025 14:59
@ChrsMark ChrsMark self-assigned this Jan 23, 2025
@braydonk
Copy link
Copy Markdown
Contributor

I believe {open_file_descriptor} is correct as a unit to match the name. This does make me wonder if the word open even needs to be in the name though; file_descriptor itself implies that it's open. Let's merge this though, and I'll make a separate issue for that now.

Comment thread model/process/metrics.yaml Outdated
Comment thread model/process/metrics.yaml Outdated
@ChrsMark
Copy link
Copy Markdown
Member Author

ChrsMark commented Feb 3, 2025

@open-telemetry/specs-semconv-maintainers shall we merge this?

@lmolkova lmolkova merged commit bd2ba6e into open-telemetry:main Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

process.open_file_descriptor.count and process.context_switches both have unexpected unit {count}

5 participants