Kubernetes: How to populate resource attributes based on attributes, labels and transformation#1756
Conversation
dashpole
left a comment
There was a problem hiding this comment.
Love the overall direction. This makes a lot of sense
|
We briefly discussed this during the k8s SemConv WG meeting. There is no consensus on the document yet, but we decided to recommend moving it from the |
@open-telemetry/specs-semconv-approvers the service page is automatically generated - how can I move the content of this PR to the service page? |
maybe as subsection(s) under https://github.com/open-telemetry/semantic-conventions/blob/main/docs/resource/README.md#service |
604cdc9 to
d850c85
Compare
|
@jsuereth @tigrannajaryan thanks for the positive feedback in the entities SIG call. A added the notes about the object hierarchy for |
|
@jinja2 thanks for the detailed review - everything should be addressed now |
|
@open-telemetry/specs-semconv-approvers please take a look Approval from the k8s semconv and entities SIG has been granted now |
Co-authored-by: Joao Grassi <[email protected]>
2a21f8c to
a5ba77b
Compare
|
@open-telemetry/specs-semconv-maintainers this seems like a good PR to include in https://changelog.opentelemetry.io. Should we add the label to it? 🤔 |
sure! I don't think it strictly falls under "New semantic convention areas or stability changes, as well as releases", but I think it's always ok for @open-telemetry/specs-semconv-maintainers to call out particularly interesting or broadly relevant changes on https://changelog.opentelemetry.io |
now that the content is moved to non-normative, it should automatically get published under https://opentelemetry.io/docs/specs/semconv/non-normative/ - IIUC |
|
@zeitlinger can you change this line in CODEOWNERS to cover this new file also (I think semantic-conventions/.github/CODEOWNERS Line 64 in d963d60 @open-telemetry/semconv-k8s-approvers does anyone else want to review before we merge? thanks! |
thanks - added |
|
@zeitlinger could you please resolve discussions (that are resolved)? Thanks! |
@lmolkova all are resolved now 😄 |
|
need #1939 to be merged first to fix CI |
Fixes #236
This is a new take on the issue. #349 has been created before and not completed.
So what's the difference now?
service.instance.idhas been completed - which was effectively a blocker before.Merge requirement checklist
[chore]