adjust process.executable.name semantic expectation#1737
adjust process.executable.name semantic expectation#1737lmolkova merged 14 commits intoopen-telemetry:mainfrom
Conversation
|
Seeing lots of good points in the discussions but having trouble figuring out where to take this. Here's my attempt to synthesize the current state:
For the most part I agree with every point of feedback I've seen, but unfortunately that means I agree with some that are that conflict with each other. So I hate to say it, but I'm kinda stuck. I don't have a good idea where to take these attributes from here. I think the only thing I'm confident on is that I'm open to suggestions on what to do with this one. |
Regarding avoiding duplication, we could specify that if |
|
I don't have a strong opinion, a few things we could consider to get unstuck:
If we go down this road ("process.name" is the best known process name), we'd be:
Either way, prototyping and final stabilization push are usually good time to clean up descriptions and also if we don't believe that some of it is essential for stability, let's just not add it or let's keep it experimental. |
All of these options imply that we'd switch the semantics for
My preference for |
That is now the purpose of this PR. |
|
@braydonk @christos68k @rockdaboot I think all the discussions can be resolved now and this PR should be ready to go. |
From my side yes, but don't have the permission to resolve my own comment 😃 |
|
Thanks @lmolkova, I resolved the comment from @rockdaboot too. PR LGTM. |
|
Should be good from my side since any open areas of concern have now been moved to #1928 |
Fixes #1736
Changes
This PR adds a new attribute
process.namethat uses the description that used to apply toprocess.executable.name. Theprocess.executable.nameattribute's description is adjusted such that the value of the attribute will reliably contain the executable name.Merge requirement checklist
[chore]