Add k8s.namespace.phase metric and attribute#1668
Merged
AlexanderWert merged 4 commits intoopen-telemetry:mainfrom Jan 21, 2025
Merged
Add k8s.namespace.phase metric and attribute#1668AlexanderWert merged 4 commits intoopen-telemetry:mainfrom
AlexanderWert merged 4 commits intoopen-telemetry:mainfrom
Conversation
ChrsMark
force-pushed
the
add_k8s_ns_phase
branch
from
9b13449 to
7e057ce
Compare
This was referenced Dec 10, 2024
dashpole
reviewed
Dec 10, 2024
dashpole
reviewed
Dec 10, 2024
dashpole
reviewed
Dec 10, 2024
povilasv
reviewed
Dec 17, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
ChrsMark
force-pushed
the
add_k8s_ns_phase
branch
3 times, most recently
from
2eb9c03 to
c50df58
Compare
dashpole
approved these changes
Jan 9, 2025
ChrsMark
force-pushed
the
add_k8s_ns_phase
branch
from
6fbc61b to
78efc98
Compare
povilasv
approved these changes
Jan 14, 2025
jinja2
reviewed
Jan 15, 2025
jinja2
approved these changes
Jan 15, 2025
ChrsMark
force-pushed
the
add_k8s_ns_phase
branch
from
ddc0634 to
0aabaa3
Compare
AlexanderWert
approved these changes
Jan 16, 2025
TylerHelmuth
approved these changes
Jan 16, 2025
trask
reviewed
Jan 17, 2025
Member
trask
left a comment
trask
left a comment
There was a problem hiding this comment.
is "phase" a common term in the context of k8s namespaces? (i.e. vs status or state)
Member
Author
I believe so. It's what the API defines and I see it's used in the docs description as well: |
lmolkova
reviewed
Jan 17, 2025
lmolkova
approved these changes
Jan 18, 2025
Signed-off-by: ChrsMark <[email protected]>
Co-authored-by: Jina Jain <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
ChrsMark
force-pushed
the
add_k8s_ns_phase
branch
from
687cef2 to
21ccf66
Compare
lmolkova
approved these changes
Jan 20, 2025
3 tasks
This was referenced May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1032
Changes
This PR adds the
k8s.namespace.phaseas metric along with its respective attributek8s.namespace.phase.This metric is already in use by the Collector and specifically the
k8sclusterreceiver.The introduced attribute is new in order to follow the modeling that is already in use by
hwmetrics andjmxmetrics mentioned at #1032 (comment) (see #1554).Collector implementation: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/9dfa2f7813b11500d001622f3d8c1dd8d9ac58fd/receiver/k8sclusterreceiver/internal/namespace/namespaces.go#L14
K8s API ref: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.30/#namespacestatus-v1-core
Merge requirement checklist
[chore]